cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (Commented) (JIRA)" <>
Subject [jira] [Commented] (CB-242) Change Reachability to PGReachability to avoid clashes
Date Wed, 08 Feb 2012 09:08:59 GMT


Shazron Abdullah commented on CB-242:

Thanks Matthew! please send a pull request to the main repo you forked off (ideally send a
pull request from a branch that contains your changes only, not master - else the pull req
could be moving target). Currently the notification system does not work - so once you send
the pull request, if you could comment in this issue so I can be notified that would be great.

I attempted this sometime ago, but other pressing issues took priority. I'll review and test,
and commit your changes if all goes well.
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>                 Key: CB-242
>                 URL:
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Matthew Lanham
>            Assignee: Shazron Abdullah
>            Priority: Minor
>             Fix For: 1.5.0
> We have been manually building each time a release is out to avoid this, often we have
libs in our iOS project that also package the Reachability class, it seems like that renaming
it is painless and causes no adverse affects, i have forked the GitHub project and made a
commit of our proposed changes, i wondered if someone could consider this being available
in the main repo.
> See commit here:

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message