cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jukka Zitting <>
Subject Re: who wants to play with me on a commit approval process for weinre?
Date Mon, 16 Jan 2012 23:57:03 GMT

On Mon, Jan 16, 2012 at 5:32 PM, Patrick Mueller <> wrote:
> Some assumptions here:
> - that we want a commit process that includes approval

Do we?

Within Apache the terms RTC and CTR (as in Review-Then-Commit [1] and
Commit-Then-Review [2]) are widely used to describe the kind of review
process used by a project. In RTC you put your changes up for review
before committing (or pushing) them to the shared trunk or master
branch. In CTR you simply commit your changes and people will review
them afterwards if or where needed.

Most Apache projects follow CTR for pretty much all actively developed
code. RTC is more commonly used for maintenance branches, APIs or
other bits that are either too complex or otherwise critical to be
changed without a full review. And even when CTR policy is used, a
committer can always call for a review of any particular change that
he or she isn't entirely sure about.

What's the process that was used within PhoneGap?

As for build system automation, probably the deepest integration so
far was done by Nigel Daley for the Hadoop project. The Hadoop build
setup takes any patches attached to the issue tracker, applies them to
the latest trunk version and runs a full set of tests on the resulting
codebase. The result of the test run is reported as a +1 or -1 comment
on the relevant issue. See Nigel's blog post [3] for more details
about the setup.

Another related tool that might be of interest is the Review Board
instance [4] that's available to help projects do code reviews of both
incoming patches and already committed changes.



Jukka Zitting

View raw message