cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] steinaragustli opened a new pull request #262: Cb 13969
Date Tue, 13 Mar 2018 11:53:35 GMT
steinaragustli opened a new pull request #262: Cb 13969
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   ### Platforms affected
   iOS and Android
   ### What does this PR do?
   Enables the position of the close/done button on inappbrowser to be swapped with the position
of the navigation buttons. See for screenshots.
It also fixes a bug in iOS where the navigation buttons are always hidden, even though the
user has 'hidenavigationbuttons=no'. Exactly where the comment "// Filter out Navigation Buttons
if user requests so" is located in "src/ios/CDVInAppBrowser.m".
   ### What testing has been done on this change?
   I have tested all possible combination of parameters when different buttons are hidden
and shown. And everything is consistent with how this should work.
   ### Checklist
   - [x] [Reported an issue]( in the JIRA
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message