From commits-return-51874-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 14 20:37:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6EEDA180621 for ; Wed, 14 Feb 2018 20:37:41 +0100 (CET) Received: (qmail 57709 invoked by uid 500); 14 Feb 2018 19:37:40 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 57700 invoked by uid 99); 14 Feb 2018 19:37:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 19:37:40 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id E922A81F80; Wed, 14 Feb 2018 19:37:39 +0000 (UTC) Date: Wed, 14 Feb 2018 19:37:39 +0000 To: "commits@cordova.apache.org" Subject: [cordova-windows] branch janpio-msbuild_cleanup updated: fix eslint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <151863705989.28550.1909671846314276374@gitbox.apache.org> From: janpio@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: cordova-windows X-Git-Refname: refs/heads/janpio-msbuild_cleanup X-Git-Reftype: branch X-Git-Oldrev: 55639d8e9a4a4a12e1d3308d479769d690fa81d5 X-Git-Newrev: 691156a3599f2af40d50c1ecb2d9d257e3718fc9 X-Git-Rev: 691156a3599f2af40d50c1ecb2d9d257e3718fc9 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-msbuild_cleanup in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-msbuild_cleanup by this push: new 691156a fix eslint 691156a is described below commit 691156a3599f2af40d50c1ecb2d9d257e3718fc9 Author: Jan Piotrowski AuthorDate: Wed Feb 14 20:37:31 2018 +0100 fix eslint --- template/cordova/lib/MSBuildTools.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/template/cordova/lib/MSBuildTools.js b/template/cordova/lib/MSBuildTools.js index cc86d9f..b8f7ea5 100644 --- a/template/cordova/lib/MSBuildTools.js +++ b/template/cordova/lib/MSBuildTools.js @@ -143,12 +143,12 @@ function checkMSBuildVersion (version) { // first, check if we have a VS 2017+ with such a version var willows = module.exports.getWillowInstallations(); - //console.log('willows', willows); + // console.log('willows', willows); var correspondingWillows = willows.filter(function (inst) { - //console.log('willows.filter', inst.version, version, inst.version === version); + // console.log('willows.filter', inst.version, version, inst.version === version); return inst.version === version; }); - //console.log('correspondingWillows', correspondingWillows); + // console.log('correspondingWillows', correspondingWillows); var correspondingWillow = correspondingWillows[0]; // TODO Do not only handle one! if (correspondingWillow) { version = '15.0'; @@ -157,7 +157,7 @@ function checkMSBuildVersion (version) { console.log('from list of VS installations: ', correspondingWillows); if (shell.test('-e', toolsPath)) { var msbuild = module.exports.getMSBuildToolsAt(toolsPath); - console.log('selected VS exists:', toolsPath, ); + console.log('selected VS exists:', toolsPath); // TODO check for JavaScript folder return msbuild; } @@ -183,8 +183,6 @@ function checkMSBuildVersion (version) { console.log('no registry result for version ' + version); // if 'reg' exits with error, assume that registry key not found }); - - console.log('no msbuild found with version ', version); } module.exports.getLatestMatchingMSBuild = function (selectedBuildTargets) { -- To stop receiving notification emails like this one, please contact janpio@apache.org. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org