From commits-return-51805-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Tue Feb 13 19:23:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05CD5180656 for ; Tue, 13 Feb 2018 19:23:25 +0100 (CET) Received: (qmail 50695 invoked by uid 500); 13 Feb 2018 18:23:25 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 50686 invoked by uid 99); 13 Feb 2018 18:23:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 18:23:25 +0000 From: GitBox To: commits@cordova.apache.org Subject: [GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion Message-ID: <151854620451.22110.5584594245345492951.gitbox@gitbox.apache.org> janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575 So I installed my branch which is giving me errors on running the test. On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` file with: ``` UAP 10.0.16299.0 10.0.10240.0 14.0 100 ``` So it updates the `TargetPlatformVersion` to the current version somewhere. Yes, there is some code for that in `prepare.js` and this is actually executed during `cordova platform add ...`. Which means that the tests should probably/maybe do something similar instead of this PR here, right? This PR is only making it possible to run the tests with a very specific setup. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org