From commits-return-51674-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 7 18:05:56 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A816618065B for ; Wed, 7 Feb 2018 18:05:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 97DDC160C5B; Wed, 7 Feb 2018 17:05:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4B90160C3C for ; Wed, 7 Feb 2018 18:05:55 +0100 (CET) Received: (qmail 85687 invoked by uid 500); 7 Feb 2018 17:05:55 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 85678 invoked by uid 99); 7 Feb 2018 17:05:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 17:05:55 +0000 From: GitBox To: commits@cordova.apache.org Subject: [GitHub] brodybits commented on a change in pull request #246: CB-13829 Fix tests that were broken since CB-13237 Message-ID: <151802315438.15980.15501454221926372647.gitbox@gitbox.apache.org> brodybits commented on a change in pull request #246: CB-13829 Fix tests that were broken since CB-13237 URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166685892 ########## File path: spec/e2e/endtoend.spec.js ########## @@ -54,34 +71,82 @@ describe('Cordova create and build', function () { expect(fs.existsSync(projectFolder)).toBe(true); }); - it('spec.2 should build project', function () { - shell.exec(buildScriptPath, {silent: true}); - var packages = shell.ls(appPackagesFolder); - expect(packages.filter(function (file) { return file.match(/.*Phone.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*\.appx.*/); }).length).toBe(1); + // default + + it('spec.2 should build default (win10) project', function () { Review comment: I wonder if this should already be spec.2a? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org