From commits-return-51161-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Thu Jan 11 18:48:22 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DC90E180656 for ; Thu, 11 Jan 2018 18:48:22 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CCBC7160C23; Thu, 11 Jan 2018 17:48:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F17F160C13 for ; Thu, 11 Jan 2018 18:48:21 +0100 (CET) Received: (qmail 87605 invoked by uid 500); 11 Jan 2018 17:48:21 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 87594 invoked by uid 99); 11 Jan 2018 17:48:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 17:48:21 +0000 From: GitBox To: commits@cordova.apache.org Subject: [GitHub] carcus88 opened a new pull request #164: Fix for CB-13774 Message-ID: <151569290076.2729.2898002977771390814.gitbox@gitbox.apache.org> carcus88 opened a new pull request #164: Fix for CB-13774 URL: https://github.com/apache/cordova-plugin-media/pull/164 Revert back to plugins original use of DEFAULT as the audio encode and decoder. ### Platforms affected Android ### What does this PR do? Puts the media encoder/decoder back to DEFAULT ### What testing has been done on this change? I created a repo that shows the current media plugin failing. Applying the code in this pull request will show it passing. https://github.com/medsurvey/cordova-media-bug The problem seems to be that somehow the encoder and decoder are set to different encoding types and are not compatible. Additionally its assuming an encoder is available on the platform and since the interface to the this object does not allow a way to specifying encoding I feel like the default may have been more appropriate. ### Checklist *Could not complete these as I don't have access* - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [] Added automated test coverage as appropriate for this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org