From commits-return-51061-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Sun Jan 7 18:16:31 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E6FFE180654 for ; Sun, 7 Jan 2018 18:16:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D75A6160C29; Sun, 7 Jan 2018 17:16:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4DCF4160C17 for ; Sun, 7 Jan 2018 18:16:31 +0100 (CET) Received: (qmail 72582 invoked by uid 500); 7 Jan 2018 17:16:30 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 72573 invoked by uid 99); 7 Jan 2018 17:16:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jan 2018 17:16:30 +0000 From: GitBox To: commits@cordova.apache.org Subject: [GitHub] jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X Message-ID: <151534538970.12640.1864222730161360243.gitbox@gitbox.apache.org> jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438 > this is a different issue Yes, it's a different issue, but there are a few people in this issue complaining about the other issue that wasn't reported because it's not clear that this PR is for when using storyboard and they are not using storyboard. That's why I created the other issue, fixed it and pointed the people to the other issue instead of complaining here. My intention is not to pollute this issue with unrelated comments, it's the opposite, to point them to the right issue. > the previous method is old anyways and people should just use the storyboard one The old method is still supported and anybody can use whatever they want > Hence this discussion should not be polluted with unrelated topics. The other topic is related, the title says "Fix image sizing on iPhone X", and people enter hopping that it fixes their issues with iPhone X image sizing, but it doesn't, the other issue fixes it. Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA for the issues, so all the discussions should be in the related JIRA and not here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org