cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] carcus88 opened a new pull request #164: Fix for CB-13774
Date Thu, 01 Jan 1970 00:00:00 GMT
carcus88 opened a new pull request #164: Fix for CB-13774
URL: https://github.com/apache/cordova-plugin-media/pull/164
 
 
   Revert back to plugins original use of DEFAULT as the audio encode and decoder.
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Puts the media encoder/decoder back to DEFAULT
   
   ### What testing has been done on this change?
   
   I created a repo that shows the current media plugin failing. Applying the code in this
pull request will show it passing.
   
   https://github.com/medsurvey/cordova-media-bug
   
   The problem seems to be that somehow the encoder and decoder are set to different encoding
types and are not compatible. Additionally its assuming an encoder is available on the platform
and since the interface to the this object does not allow a way to specifying encoding I feel
like the default may have been more appropriate. 
   
   ### Checklist
   *Could not complete these as I don't have access*
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [] Added automated test coverage as appropriate for this change.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message