Return-Path: <commits-return-50443-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 2A000200D56
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 12 Dec 2017 21:18:59 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 286F4160C00; Tue, 12 Dec 2017 20:18:59 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 6FE1E160BE7
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 12 Dec 2017 21:18:58 +0100 (CET)
Received: (qmail 62857 invoked by uid 500); 12 Dec 2017 20:18:57 -0000
Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cordova.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cordova.apache.org>
List-Post: <mailto:commits@cordova.apache.org>
List-Id: <commits.cordova.apache.org>
Delivered-To: mailing list commits@cordova.apache.org
Received: (qmail 62848 invoked by uid 99); 12 Dec 2017 20:18:57 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 20:18:57 +0000
From: GitBox <git@apache.org>
To: commits@cordova.apache.org
Subject: [GitHub] macdonst commented on a change in pull request #253: CB-13662: remove deprecated platforms
Message-ID: <151310993707.23497.504457735304760938.gitbox@gitbox.apache.org>
archived-at: Tue, 12 Dec 2017 20:18:59 -0000

macdonst commented on a change in pull request #253: CB-13662: remove deprecated platforms
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/253#discussion_r156483934
 
 

 ##########
 File path: plugin.xml
 ##########
 @@ -147,52 +101,6 @@
         <source-file src="src/osx/CDVInAppBrowser.m" />
     </platform>
 
-    <!-- wp7 -->
-    <platform name="wp7">
-        <config-file target="Properties/WMAppManifest.xml" parent="/Deployment/App/Capabilities">
-            <Capability Name="ID_CAP_NETWORKING"/>
-        </config-file>
-
-        <js-module src="www/inappbrowser.js" name="inappbrowser">
-            <clobbers target="cordova.InAppBrowser.open" />
-            <clobbers target="window.open" />
-        </js-module>
-        <config-file target="config.xml" parent="/*">
-            <feature name="InAppBrowser">
-                <param name="wp-package" value="InAppBrowser"/>
-            </feature>
-        </config-file>
-
-        <config-file target="Properties/WMAppManifest.xml" parent="/Deployment/App/Capabilities">
-            <Capability Name="ID_CAP_NETWORKING" />
-        </config-file>
-
-        <source-file src="src/wp/InAppBrowser.cs" />
-    </platform>
-
-    <!-- wp8 -->
-    <platform name="wp8">
-        <config-file target="Properties/WMAppManifest.xml" parent="/Deployment/App/Capabilities">
-            <Capability Name="ID_CAP_NETWORKING"/>
-        </config-file>
-
-        <js-module src="www/inappbrowser.js" name="inappbrowser">
-            <clobbers target="cordova.InAppBrowser.open" />
-            <clobbers target="window.open" />
-        </js-module>
-        <config-file target="config.xml" parent="/*">
-            <feature name="InAppBrowser">
-                <param name="wp-package" value="InAppBrowser"/>
-            </feature>
-        </config-file>
-
-        <config-file target="Properties/WMAppManifest.xml" parent="/Deployment/App/Capabilities">
-            <Capability Name="ID_CAP_NETWORKING" />
-        </config-file>
-
-        <source-file src="src/wp/InAppBrowser.cs" />
-    </platform>
-
     <!-- windows8 -->
 
 Review comment:
   @surajpindoria I think you want to get rid of this platform too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org