cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DanWithams7d opened a new pull request #161: CB-13693: Improves Documentation
Date Thu, 01 Jan 1970 00:00:00 GMT
DanWithams7d opened a new pull request #161: CB-13693: Improves Documentation
URL: https://github.com/apache/cordova-plugin-contacts/pull/161
 
 
   The explanation of the contactFields argument in the 'navigator.contacts.find' section
is unclear and ambiguous. Updating to make it clearer to people wanting to utilise this plugin.
   
   1) At no point is the argument data type described (array0
   2) The statement for using "*" to search all fields is ambiguous due to a combination of
point 1) and direct ambiguity in the statement itself (the description of the value of the
argument by providing a STRING example rather than an ARRAY example.
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   None
   
   ### What does this PR do?
   Improves documentation
   
   ### What testing has been done on this change?
   Not applicable, it's documentation changes.
   
   ### Checklist
   - [Y] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   https://issues.apache.org/jira/browse/CB-13693
   - [Y] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [Y] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message