cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] janpio commented on a change in pull request #244: CB-13641: (windows) allow for transparent splash screen background co?
Date Thu, 01 Jan 1970 00:00:00 GMT
janpio commented on a change in pull request #244: CB-13641: (windows) allow for transparent
splash screen background co?
URL: https://github.com/apache/cordova-windows/pull/244#discussion_r155587124
 
 

 ##########
 File path: cordova-js-src/splashscreen.js
 ##########
 @@ -212,7 +215,7 @@ function exitFullScreen() {
 // Make title bg color match splashscreen bg color
 function colorizeTitleBar() {
     var appView = Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
-    if (isWin10UWP) {
+    if (isWin10UWP && (typeof titleBgColor !== 'undefined')) {
 
 Review comment:
   First I thought you could just check if bgColor == 'transparent`, but that doesn't exist
here. `isTitleBgTransparent` would be a solution and probably more readable, also makes the
special case explicit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message