Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: GitBox <git@apache.org>
To: commits@cordova.apache.org
Subject: [GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?
Message-ID: <151065594097.398.11057064397331468851.gitbox@gitbox.apache.org>
archived-at: Tue, 14 Nov 2017 10:39:02 -0000

janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?
URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795285
 
 
 ##########
 File path: doc/building-and-deploying-the-website.md
 ##########
 @@ -0,0 +1,22 @@
+## Building and Deploying (Automated)
+
+### Testing
+
+After you are finished developing and making your changes, make sure to test them. Run:
+
+	npm test
+
+`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github.
+
+### Travis 
+
+[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. 
+
+Lastly, Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review.
 
 Review comment:
   Why the seperate "Testing" paragraph if Travis automatically runs the tests? Is this a safeguard somehow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org