Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: GitBox <git@apache.org>
To: commits@cordova.apache.org
Subject: [GitHub] jonathanli2 opened a new pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller
Message-ID: <151016982048.30867.4638295661717895732.gitbox@gitbox.apache.org>
archived-at: Wed, 08 Nov 2017 19:37:02 -0000

jonathanli2 opened a new pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller
URL: https://github.com/apache/cordova-plugin-dialogs/pull/98
 
 
   ?resented
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Fix the issue of not showing the dialog screen if inappbrowser screen is presented
   [https://issues.apache.org/jira/browse/CB-13555](https://issues.apache.org/jira/browse/CB-13555)
   
   ### What testing has been done on this change?
   Create a cordova ios project with UIWebView or WKWebView, and call the below method. The dialog view does not show to user.
   
   function confirm(){
       var win = window.open( "https://www.google.com", "_blank" );
       win.addEventListener( "loadstop", function() {
       setTimeout(function() {
            function onConfirm(buttonIndex) {
               console.log('You selected button ' + buttonIndex);
           }
           
           navigator.notification.confirm(
               'You are the winner!', // message
               onConfirm,            // callback to invoke with index of button pressed
               'Game Over',           // title
               ['Restart','Exit']     // buttonLabels
   );
       }, 1000 );
   });
   }
   
   ### Checklist
   - [Y] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [Y] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [N] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org