cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios
Date Thu, 01 Jan 1970 00:00:00 GMT
jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347968656
 
 
   Hey thanks for chiming in!
   
   **Why would a developer want to have an inappbrowser window with no close button?**
   Simple, because the inappbrowser should not be closed in the app I'm building
   **As a user of the app, how would you close the inappbrowser?**
   The user is not supposed to close it :-) The app is basically wrapping a web app using
the inappbrowser. It runs it's own javascriptcontext in the main webview of the app. The main
webview handles push notifications, log in functionallity, sharing of content to the application
from other apps on the device, the inappbrowser show the web app. The user does al his/her
work in the web app.
   **Why would this be an iOS specific feature only?**
   On android, we just do not show the toolbar at all so the problem does not exist there.
But on ios, we want to retain the forward/backwards control of the toolbar because ios has
no backbutton in it's ui. So we want to have a toolbar with just the navigational controls.
current situation on ios is that you get both, the nav controls and the close button.  
   
   **To me this seems like a very specific use case that doesn't warrant adding it back to
the main plugin repo.**
   Of course it's a specific use case, i won't argue with that. But why not offer the option
when it's so easy to implement. Why limit ourselves to an 'all or nothing' toolbar :-)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message