cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] janpio commented on a change in pull request #722: Update index.md
Date Thu, 01 Jan 1970 00:00:00 GMT
janpio commented on a change in pull request #722: Update index.md
URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151362073
 
 

 ##########
 File path: www/docs/en/6.x/guide/platforms/android/index.md
 ##########
 @@ -310,7 +310,7 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI][cli_reference] `build` or `run` commands.
 
-__Note__: You should use double `--` to indicate that these are platform-specific arguments,
for example:
+__Note__: You should use double `--` (followed by a space) to indicate that these are platform-specific
arguments, for example:
 
 Review comment:
   They do, but content is strange now (doesn't really make sense).
   
   Because your original branch/fork is gone, you should create a new branch in your current
fork, edit all 3 files in that fork (you can do that manually in the UI) and then create a
Pull Request from that fork. That should then add these 3 commits to one Pull Request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message