cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nadavmos commented on issue #139: Update CDVSplashScreen.m
Date Thu, 01 Jan 1970 00:00:00 GMT
nadavmos commented on issue #139: Update CDVSplashScreen.m
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/139#issuecomment-344570981
 
 
   .. and you are also missing the asset catalog version prefix for iphoneX, see below:  
   
   // Add Asset Catalog specific prefixes
       if ([imageName isEqualToString:@"LaunchImage"])
       {
           if (device.iPhone4 || device.iPhone5 || device.iPad) {
               imageName = [imageName stringByAppendingString:@"-700"];
           } else if(device.iPhone6) {
               imageName = [imageName stringByAppendingString:@"-800"];
           } else if(device.iPhone6Plus) {
               imageName = [imageName stringByAppendingString:@"-800"];
               if (currentOrientation == UIInterfaceOrientationPortrait || currentOrientation
== UIInterfaceOrientationPortraitUpsideDown)
               {
                   imageName = [imageName stringByAppendingString:@"-Portrait"];
               }
           **} else if(device.iPhoneX) {
                imageName = [imageName stringByAppendingString:@"-1100"];
           }**
       }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message