Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 78600200D26 for ; Fri, 20 Oct 2017 16:56:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 76FB9160BCB; Fri, 20 Oct 2017 14:56:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B9B751609E1 for ; Fri, 20 Oct 2017 16:56:13 +0200 (CEST) Received: (qmail 76071 invoked by uid 500); 20 Oct 2017 14:56:12 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 76062 invoked by uid 99); 20 Oct 2017 14:56:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 14:56:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CF8ECDFA29; Fri, 20 Oct 2017 14:56:12 +0000 (UTC) From: jcesarmobile To: commits@cordova.apache.org Reply-To: commits@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-statusbar pull request #: Content-Type: text/plain Message-Id: <20171020145612.CF8ECDFA29@git1-us-west.apache.org> Date: Fri, 20 Oct 2017 14:56:12 +0000 (UTC) archived-at: Fri, 20 Oct 2017 14:56:14 -0000 Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/fff289c0b8a7d0eb5b94f06d8ace9733054185bd#commitcomment-25098208 @spurreiter thanks for the comment, you are right, I just added that code to make it build on Xcode 8, but forgot that the apps built with Xcode 8 will also work on iOS 11 and the code won't be executed in that case. Nevertheless, next time better report issues like this on http://issues.cordova.io/, as comments on commits might be missed. I have already [reported it](https://issues.apache.org/jira/browse/CB-13476) and[ sent a PR](https://github.com/apache/cordova-plugin-statusbar/pull/90) based on your comment. Thanks again! --- --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org