Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: GitBox <git@apache.org>
To: commits@cordova.apache.org
Subject: [GitHub] surajpindoria opened a new pull request #344: CB-13290: (ios) Update splash screen mapping for missing devices
Message-ID: <150887803079.16380.4264498404198861804.gitbox@gitbox.apache.org>
archived-at: Tue, 24 Oct 2017 20:47:12 -0000

surajpindoria opened a new pull request #344: CB-13290: (ios) Update splash screen mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Adds splash screen support for iPhone X and other missing devices.
   
   ### What testing has been done on this change?
   Created a project with all supported splash screens, opened in Xcode and viewed the Images.xcassets to see that the splash screens were correctly added.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org