cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dnfield <>
Subject [GitHub] cordova-plugin-statusbar pull request #88: Hide status bar in iPhone X lands...
Date Wed, 04 Oct 2017 15:35:26 GMT
GitHub user dnfield opened a pull request:

    Hide status bar in iPhone X landscape

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    iOS 11, on iPhone X
    ### What does this PR do?
    Hides the statusbar in landscape mode on iPhone X devices
    ### What testing has been done on this change?
    Testing in emulator
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    This change fixes issues with statusbar visibility while in landscape mode on an iPhone
X.  The status bar should not be visible in landscape mode on the new devices, and visibility
should be restored when in Landscape (unless `hide()` has been called from JavaScript).

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #88



To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message