cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mino922 <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #289: CB-133332: (iOS) Error When Taking ...
Date Fri, 06 Oct 2017 04:29:14 GMT
GitHub user mino922 opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/289

    CB-133332: (iOS) Error When Taking Picture Missing NSPhotoLibraryAddU…

    …sageDescription
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes issues in iOS when taking a photo where app would crash because of missing NSPhotoLibraryUsageDescription
    
    ### What testing has been done on this change?
    Change was tested on an ionic app on iPhone 6s running iOS 11.
    
    
    ### Checklist
    - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mino922/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----
commit a951cade16fc9206ada28ceff3980bc921b494ca
Author: mino922 <samuelpmino@gmail.com>
Date:   2017-10-06T04:24:21Z

    CB-133332 iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message