cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kelvindart <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #220: CB-13294 Remove cordova-plugin-compat
Date Wed, 18 Oct 2017 22:51:27 GMT
GitHub user kelvindart opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/220

    CB-13294 Remove cordova-plugin-compat

    ### Platforms affected
    cordova-android@6.3.0
    
    ### What does this PR do?
    Removes the dependency on cordova-plugin-compat, and includes checks for min platform
version.
    
    ### What testing has been done on this change?
    Testing 1:
    - Add local plugin to project containing cordova-android@6.3.0
    - Verify plugin installs, and app runs.
    
    Testing 2:
    - Add local plugin to project containing cordova-android@6.2.3
    - Verify plugin does not install.
    - Console log as follows:
    
    ```
    Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3,
failed version requirement: >=6.3.0
    Skipping 'cordova-plugin-file' for android
    ```
    
    This is desirable - this change stops the plugin being installed on `<cordova-android@6.3.0`
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kelvindart/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message