cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
Date Thu, 01 Jan 1970 00:00:00 GMT
macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340590032
 
 
   @infil00p okay, got it. Once I do that step I get a bit farther but then I run into other
problems. The plugin doesn't compile because it is missing all of the frameworks it depends
on. For instance the push plugin includes:
   
   ```
       <framework src="com.android.support:support-v13:26.+"/>
       <framework src="me.leolin:ShortcutBadger:1.1.17@aar"/>
       <framework src="com.google.firebase:firebase-messaging:$FCM_VERSION"/>
       <framework src="push.gradle" custom="true" type="gradleReference"/>
   ```
   
   None of those things seem to get included in `build.gradle`. Previously I'd see:
   
   ```
   // PLUGIN GRADLE EXTENSIONS START
   apply from: "phonegap-plugin-push/app-push.gradle"
   // PLUGIN GRADLE EXTENSIONS END
   
   dependencies {
       compile fileTree(dir: 'libs', include: '*.jar')
       // SUB-PROJECT DEPENDENCIES START
       debugCompile(project(path: "CordovaLib", configuration: "debug"))
       releaseCompile(project(path: "CordovaLib", configuration: "release"))
       compile "com.android.support:support-v13:26.+"
       compile "me.leolin:ShortcutBadger:1.1.17@aar"
       compile "com.google.firebase:firebase-messaging:11.0.1"
       // SUB-PROJECT DEPENDENCIES END
   }
   ```
   
   But with this change I only see:
   
   ```
   dependencies {
       compile fileTree(dir: 'libs', include: '*.jar')
       // SUB-PROJECT DEPENDENCIES START
       debugCompile(project(path: ":CordovaLib", configuration: "debug"))
       releaseCompile(project(path: ":CordovaLib", configuration: "release"))
       // SUB-PROJECT DEPENDENCIES END
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message