cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Stefano1964 commented on a change in pull request #344: CB-13290: (ios) Update splash screen mapping for missing devices
Date Thu, 01 Jan 1970 00:00:00 GMT
Stefano1964 commented on a change in pull request #344: CB-13290: (ios) Update splash screen
mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146696410
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/prepare.js
 ##########
 @@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens, splashScreensDir) {
         {dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
         {dest: 'Default-667h.png', width: 750, height: 1334},
         {dest: 'Default-736h.png', width: 1242, height: 2208},
-        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+        {dest: 'Default-2436h.png', width: 1125, height: 2436},
+        {dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
 
 Review comment:
   We have also to modify splashscreen plugin but there is a bug in xCode actually for generated
image (it's seem to be solve in xCode 9.1):
   https://stackoverflow.com/questions/46263795/iphone-x-incorrect-launch-screen-orientation-used
   I make it work (portrait only) with launch-screen image and by modifying splashscreen plugin,
no reason to use launch storyboard, with launch-screen you have more granular control over
your splash

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message