Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: stevengill <git@git.apache.org>
To: commits@cordova.apache.org
Reply-To: commits@cordova.apache.org
References: <git-pr-27-cordova-plugin-test-framework@git.apache.org>
In-Reply-To: <git-pr-27-cordova-plugin-test-framework@git.apache.org>
Subject: [GitHub] cordova-plugin-test-framework pull request #27: CB-13342 : Updated README.md...
Content-Type: text/plain
Message-Id: <20170929234927.2F264F5C0E@git1-us-west.apache.org>
Date: Fri, 29 Sep 2017 23:49:26 +0000 (UTC)
archived-at: Fri, 29 Sep 2017 23:49:30 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-test-framework/pull/27#discussion_r141247633
  
    --- Diff: README.md ---
    @@ -62,6 +62,10 @@ Add a directory named `tests` to the root of your plugin. Within this directory,
     
     For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](https://github.com/apache/cordova-plugin-device/blob/master/tests/plugin.xml).
     
    +Create a `package.json` inside your project's `tests/` folder. The latest version of the tools ensure to run `npm install` on any plugin added to a project and pull in any dependencies. Therefore, plugin authors can now put npm dependencies around their tests into the `package.json` file.
    --- End diff --
    
    Maybe before the second sentence, add a sentence about plugins requiring `package.json` now and tests are considered their own plugins. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org