cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #242: CB-13309: InAppBrowser as a L...
Date Thu, 21 Sep 2017 17:54:22 GMT
GitHub user infil00p opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/242

    CB-13309: InAppBrowser as a Library Project

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This changes the Android code so that the plugin is installed as a Library Project, and
the Assets, Code and Layout are managed in their own project instead of copied into the generated
project.
    
    ### What testing has been done on this change?
    * Tested against mobilespec
    * Tested against CI
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-plugin-inappbrowser modulework

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
    
----
commit 796761029a2fad587c6ade5b2d67109b9095a2ac
Author: Joe Bowser <bowserj@apache.org>
Date:   2016-04-07T17:09:49Z

    Adding the Library Project

commit 899fe80c43ac2c20e05ef9ad9679e2855bf38ddd
Author: Joe Bowser <bowserj@apache.org>
Date:   2016-06-06T22:44:00Z

    Tweaking to get framework install kinda working

commit 8e2acd7066bafb09fe112d565ded6d1be247140c
Author: Joe Bowser <bowserj@apache.org>
Date:   2016-06-07T23:05:32Z

    Got a gradle that makes submodules work.  This took a long time to figure out.

commit a4dea54087ce922551bd13410ce6901d2edbb1dd
Author: Joe Bowser <bowserj@apache.org>
Date:   2016-06-08T18:01:40Z

    Adding publishNonDefault for debug and non-debug builds, because Cordova will add seperate
rules for both

commit 4b61238598a2c644f996354e100c482a2154eab6
Author: Joe Bowser <bowserj@apache.org>
Date:   2016-06-29T18:22:00Z

    Attempting to make Cordova standalone so we can query dependencies

commit a84a51b401a96b9c9fc868c18d1b935ed464c521
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-09-21T16:48:36Z

    Merge branch 'master' into modulework
    
    Necessary Merge Commit to bring this old POC into modern usage

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message