cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-plugin-test-framework pull request #27: CB-13342 : Updated README.md...
Date Fri, 29 Sep 2017 23:49:26 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-test-framework/pull/27#discussion_r141247633
  
    --- Diff: README.md ---
    @@ -62,6 +62,10 @@ Add a directory named `tests` to the root of your plugin. Within this
directory,
     
     For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](https://github.com/apache/cordova-plugin-device/blob/master/tests/plugin.xml).
     
    +Create a `package.json` inside your project's `tests/` folder. The latest version of
the tools ensure to run `npm install` on any plugin added to a project and pull in any dependencies.
Therefore, plugin authors can now put npm dependencies around their tests into the `package.json`
file.
    --- End diff --
    
    Maybe before the second sentence, add a sentence about plugins requiring `package.json`
now and tests are considered their own plugins. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message