cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #243: CB-5758: (android/ios) suppor...
Date Wed, 27 Sep 2017 16:43:35 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/243#discussion_r141401812
  
    --- Diff: src/android/InAppBrowser.java ---
    @@ -879,6 +910,48 @@ private void sendUpdate(JSONObject obj, boolean keepCallback, PluginResult.Statu
             }
         }
     
    +    private void addTrustedCA() throws IOException, NoSuchAlgorithmException, CertificateException,
KeyManagementException, KeyStoreException {
    +        Log.d(LOG_TAG, "Adding trusted certificate if it exists");
    --- End diff --
    
    We use our own LOG, not the Android log.  This is causing compile errors in Travis CI.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message