cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject cordova-serve git commit: CB-13188: updated broken promise, set serve to use default browser if none is provided
Date Thu, 24 Aug 2017 20:34:59 GMT
Repository: cordova-serve
Updated Branches:
  refs/heads/master 889befc8d -> 446d68c09


CB-13188: updated broken promise, set serve to use default browser if none is provided

 This closes #4


Project: http://git-wip-us.apache.org/repos/asf/cordova-serve/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-serve/commit/446d68c0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-serve/tree/446d68c0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-serve/diff/446d68c0

Branch: refs/heads/master
Commit: 446d68c098297c14d8d4cf214f26b71f9cd0d540
Parents: 889befc
Author: Steve Gill <stevengill97@gmail.com>
Authored: Wed Aug 23 17:47:31 2017 -0700
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Thu Aug 24 13:34:52 2017 -0700

----------------------------------------------------------------------
 src/browser.js  | 2 +-
 src/main.js     | 2 +-
 src/platform.js | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-serve/blob/446d68c0/src/browser.js
----------------------------------------------------------------------
diff --git a/src/browser.js b/src/browser.js
index 07a93ac..61f8509 100644
--- a/src/browser.js
+++ b/src/browser.js
@@ -39,7 +39,7 @@ var NOT_SUPPORTED = 'The browser target is not supported: %target%';
 module.exports = function (opts) {
 
     opts = opts || {};
-    var target = opts.target || 'chrome';
+    var target = opts.target || 'default';
     var url = opts.url || '';
 
     target = target.toLowerCase();

http://git-wip-us.apache.org/repos/asf/cordova-serve/blob/446d68c0/src/main.js
----------------------------------------------------------------------
diff --git a/src/main.js b/src/main.js
index d8b41bd..996798d 100644
--- a/src/main.js
+++ b/src/main.js
@@ -50,7 +50,7 @@ function CordovaServe () {
     this.launchBrowser = require('./browser');
 }
 
-// module.exports.launchBrowser = require('./browser');
+module.exports.launchBrowser = require('./browser');
 
 // Expose some useful express statics
 module.exports.Router = express.Router;

http://git-wip-us.apache.org/repos/asf/cordova-serve/blob/446d68c0/src/platform.js
----------------------------------------------------------------------
diff --git a/src/platform.js b/src/platform.js
index 99a4f87..f98cf26 100644
--- a/src/platform.js
+++ b/src/platform.js
@@ -47,7 +47,7 @@ module.exports = function (platform, opts) {
             if (!fs.existsSync(opts.root)) {
                 reject(new Error('Error: Project does not include the specified platform:
' + platform));
             } else {
-                return that.launchServer(opts);
+                return resolve(that.launchServer(opts));
             }
         }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message