cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audre...@apache.org
Subject [10/18] cordova-lib git commit: CB-12895 : ran eslint --fix on cordova-lib
Date Fri, 28 Jul 2017 18:26:41 GMT
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/emulate.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/emulate.spec.js b/spec/cordova/emulate.spec.js
index 111bb78..f698a2e 100644
--- a/spec/cordova/emulate.spec.js
+++ b/spec/cordova/emulate.spec.js
@@ -16,20 +16,24 @@
     specific language governing permissions and limitations
     under the License.
 */
-var cordova = require('../../src/cordova/cordova'),
-    platforms = require('../../src/platforms/platforms'),
-    HooksRunner = require('../../src/hooks/HooksRunner'),
-    Q = require('q'),
-    util = require('../../src/cordova/util');
+var cordova = require('../../src/cordova/cordova');
+var platforms = require('../../src/platforms/platforms');
+var HooksRunner = require('../../src/hooks/HooksRunner');
+var Q = require('q');
+var util = require('../../src/cordova/util');
 
-var supported_platforms = Object.keys(platforms).filter(function(p) { return p != 'www'; });
+var supported_platforms = Object.keys(platforms).filter(function (p) { return p !== 'www'; });
 
-describe('emulate command', function() {
-    var is_cordova, cd_project_root, list_platforms, fire, fail;
+describe('emulate command', function () {
+    var is_cordova;
+    var cd_project_root; // eslint-disable-line no-unused-vars
+    var list_platforms;
+    var fire;
+    var fail;
     var project_dir = '/some/path';
     var prepare_spy, platformApi, getPlatformApi;
 
-    beforeEach(function() {
+    beforeEach(function () {
         is_cordova = spyOn(util, 'isCordova').and.returnValue(project_dir);
         cd_project_root = spyOn(util, 'cdProjectRoot').and.returnValue(project_dir);
         list_platforms = spyOn(util, 'listPlatforms').and.returnValue(supported_platforms);
@@ -40,152 +44,158 @@ describe('emulate command', function() {
             run: jasmine.createSpy('run').and.returnValue(Q()),
             build: jasmine.createSpy('build').and.returnValue(Q())
         };
-        
+
         getPlatformApi = spyOn(platforms, 'getPlatformApi').and.returnValue(platformApi);
     });
-    describe('failure', function() {
-        it('Test 001 : should not run inside a Cordova-based project with no added platforms by calling util.listPlatforms', function(done) {
+    describe('failure', function () {
+        it('Test 001 : should not run inside a Cordova-based project with no added platforms by calling util.listPlatforms', function (done) {
             list_platforms.and.returnValue([]);
             var success = jasmine.createSpy('success');
             cordova.compile()
-            .then(success, function(result) {
-                expect(result instanceof Error).toBe(true);
-                expect('' + result).toContain('No platforms added to this project. Please use `cordova platform add <platform>`.');
-            })
-            .fin(function() {
-                expect(success).not.toHaveBeenCalled();
-                done();
-            });
+                .then(success, function (result) {
+                    expect(result instanceof Error).toBe(true);
+                    expect('' + result).toContain('No platforms added to this project. Please use `cordova platform add <platform>`.');
+                })
+                .fin(function () {
+                    expect(success).not.toHaveBeenCalled();
+                    done();
+                });
         });
-        it('Test 002 : should not run outside of a Cordova-based project', function(done) {
+        it('Test 002 : should not run outside of a Cordova-based project', function (done) {
             is_cordova.and.returnValue(false);
             var success = jasmine.createSpy('success');
             cordova.compile()
-            .then(success, function(result) {
-                expect(result instanceof Error).toBe(true);
-            })
-            .fin(function() {
-                expect(success).not.toHaveBeenCalled();
-                done();
-            });
+                .then(success, function (result) {
+                    expect(result instanceof Error).toBe(true);
+                })
+                .fin(function () {
+                    expect(success).not.toHaveBeenCalled();
+                    done();
+                });
         });
     });
 
-    describe('success', function() {
-        it('Test 003 : should run inside a Cordova-based project with at least one added platform and call prepare and shell out to the emulate script', function(done) {
-            cordova.emulate(['android','ios']).then(function(err) {
-                expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['android', 'ios']}));
-                expect(getPlatformApi).toHaveBeenCalledWith('android');
-                expect(getPlatformApi).toHaveBeenCalledWith('ios');
-                expect(platformApi.build).toHaveBeenCalled();
-                expect(platformApi.run).toHaveBeenCalled();
-            })
-            .fail(fail)
-            .fin(done);
+    describe('success', function () {
+        it('Test 003 : should run inside a Cordova-based project with at least one added platform and call prepare and shell out to the emulate script', function (done) {
+            cordova.emulate(['android', 'ios'])
+                .then(function (err) { // eslint-disable-line handle-callback-err
+                    expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['android', 'ios']}));
+                    expect(getPlatformApi).toHaveBeenCalledWith('android');
+                    expect(getPlatformApi).toHaveBeenCalledWith('ios');
+                    expect(platformApi.build).toHaveBeenCalled();
+                    expect(platformApi.run).toHaveBeenCalled();
+                })
+                .fail(fail)
+                .fin(done);
         });
-        it('Test 004 : should pass down options', function(done) {
-            cordova.emulate({platforms: ['ios'], options: {optionTastic: true }}).then(function(err) {
-                expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
-                expect(getPlatformApi).toHaveBeenCalledWith('ios');
-                expect(platformApi.build).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true });
-                expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true, nobuild: true });
-            })
-            .fail(fail)
-            .fin(done);
+        it('Test 004 : should pass down options', function (done) {
+            cordova.emulate({platforms: ['ios'], options: { optionTastic: true }})
+                .then(function (err) { // eslint-disable-line handle-callback-err
+                    expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
+                    expect(getPlatformApi).toHaveBeenCalledWith('ios');
+                    expect(platformApi.build).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true });
+                    expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true, nobuild: true });
+                })
+                .fail(fail)
+                .fin(done);
         });
         it('Test 005 : should convert options from old format and warn user about this', function (done) {
-            function warnSpy(message) {
+            function warnSpy (message) {
                 expect(message).toMatch('The format of cordova.* methods "options" argument was changed');
             }
 
             cordova.on('warn', warnSpy);
-            cordova.emulate({platforms:['ios'], options:['--optionTastic']}).then(function () {
-                expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
-                expect(getPlatformApi).toHaveBeenCalledWith('ios');
-                expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({emulator: true, argv: ['--optionTastic']}));
-            })
-            .fail(fail)
-            .fin(function () {
-                cordova.off('warn', warnSpy);
-                done();
-            });
+            cordova.emulate({platforms: ['ios'], options: ['--optionTastic']})
+                .then(function () {
+                    expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
+                    expect(getPlatformApi).toHaveBeenCalledWith('ios');
+                    expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({emulator: true, argv: ['--optionTastic']}));
+                })
+                .fail(fail)
+                .fin(function () {
+                    cordova.off('warn', warnSpy);
+                    done();
+                });
         });
-        describe('run parameters should not be altered by intermediate build command', function() {
+        describe('run parameters should not be altered by intermediate build command', function () {
             var originalBuildSpy;
-            beforeEach(function() {
+            beforeEach(function () {
                 originalBuildSpy = platformApi.build;
-                platformApi.build = jasmine.createSpy('build').and.callFake(function(opts) {
+                platformApi.build = jasmine.createSpy('build').and.callFake(function (opts) {
                     opts.couldBeModified = 'insideBuild';
                     return Q();
                 });
             });
-            afterEach(function() {
+            afterEach(function () {
                 platformApi.build = originalBuildSpy;
             });
-            it('Test 006 : should leave parameters unchanged', function(done) {
-                cordova.run({platforms: ['blackberry10'], options:{password: '1q1q'}}).then(function() {
-                    expect(prepare_spy).toHaveBeenCalledWith({ platforms: [ 'blackberry10' ], options: { password: '1q1q', 'couldBeModified': 'insideBuild' }, verbose: false });
-                    expect(platformApi.build).toHaveBeenCalledWith({password: '1q1q', 'couldBeModified': 'insideBuild'});
-                    expect(platformApi.run).toHaveBeenCalledWith({password: '1q1q', nobuild: true});
-                }, function(err) {
-                    expect(err).toBeUndefined();
-                }).fin(done);
+            it('Test 006 : should leave parameters unchanged', function (done) {
+                cordova.run({platforms: ['blackberry10'], options: {password: '1q1q'}})
+                    .then(function () {
+                        expect(prepare_spy).toHaveBeenCalledWith({ platforms: [ 'blackberry10' ], options: { password: '1q1q', 'couldBeModified': 'insideBuild' }, verbose: false });
+                        expect(platformApi.build).toHaveBeenCalledWith({password: '1q1q', 'couldBeModified': 'insideBuild'});
+                        expect(platformApi.run).toHaveBeenCalledWith({password: '1q1q', nobuild: true});
+                    }, function (err) {
+                        expect(err).toBeUndefined();
+                    }).fin(done);
             });
         });
 
         it('Test 007 : should call platform\'s build method', function (done) {
             cordova.emulate({platforms: ['blackberry10']})
-            .then(function() {
-                expect(prepare_spy).toHaveBeenCalled();
-                expect(platformApi.build).toHaveBeenCalledWith({device: false, emulator: true});
-                expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({nobuild: true}));
-            }, function(err) {
-                expect(err).toBeUndefined();
-            })
-            .fin(done);
+                .then(function () {
+                    expect(prepare_spy).toHaveBeenCalled();
+                    expect(platformApi.build).toHaveBeenCalledWith({device: false, emulator: true});
+                    expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({nobuild: true}));
+                }, function (err) {
+                    expect(err).toBeUndefined();
+                })
+                .fin(done);
         });
 
         it('Test 008 : should not call build if --nobuild option is passed', function (done) {
             cordova.emulate({platforms: ['blackberry10'], options: { nobuild: true }})
-            .then(function() {
-                expect(prepare_spy).toHaveBeenCalled();
-                expect(platformApi.build).not.toHaveBeenCalled();
-                expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({nobuild: true}));
-            }, function(err) {
-                expect(err).toBeUndefined();
-            })
-            .fin(done);
+                .then(function () {
+                    expect(prepare_spy).toHaveBeenCalled();
+                    expect(platformApi.build).not.toHaveBeenCalled();
+                    expect(platformApi.run).toHaveBeenCalledWith(jasmine.objectContaining({nobuild: true}));
+                }, function (err) {
+                    expect(err).toBeUndefined();
+                })
+                .fin(done);
         });
     });
 
-    describe('hooks', function() {
-        describe('when platforms are added', function() {
-            it('Test 009 : should fire before hooks through the hooker module', function(done) {
-                cordova.emulate(['android', 'ios']).then(function() {
-                    expect(fire).toHaveBeenCalledWith('before_emulate',
-                        jasmine.objectContaining({verbose: false, platforms:['android', 'ios'], options: jasmine.any(Object)}));
-                })
-                .fail(fail)
-                .fin(done);
+    describe('hooks', function () {
+        describe('when platforms are added', function () {
+            it('Test 009 : should fire before hooks through the hooker module', function (done) {
+                cordova.emulate(['android', 'ios'])
+                    .then(function () {
+                        expect(fire).toHaveBeenCalledWith('before_emulate',
+                            jasmine.objectContaining({verbose: false, platforms: ['android', 'ios'], options: jasmine.any(Object)}));
+                    })
+                    .fail(fail)
+                    .fin(done);
             });
-            it('Test 010 : should fire after hooks through the hooker module', function(done) {
-                cordova.emulate('android').then(function() {
-                     expect(fire).toHaveBeenCalledWith('after_emulate',
-                        jasmine.objectContaining({verbose: false, platforms:['android'], options: jasmine.any(Object)}));
-                })
-                .fail(fail)
-                .fin(done);
+            it('Test 010 : should fire after hooks through the hooker module', function (done) {
+                cordova.emulate('android')
+                    .then(function () {
+                        expect(fire).toHaveBeenCalledWith('after_emulate',
+                            jasmine.objectContaining({verbose: false, platforms: ['android'], options: jasmine.any(Object)}));
+                    })
+                    .fail(fail)
+                    .fin(done);
             });
         });
 
-        describe('with no platforms added', function() {
-            it('Test 011 : should not fire the hooker', function(done) {
+        describe('with no platforms added', function () {
+            it('Test 011 : should not fire the hooker', function (done) {
                 list_platforms.and.returnValue([]);
-                Q().then(cordova.emulate).then(function() {
+                Q().then(cordova.emulate).then(function () {
                     expect('this call').toBe('fail');
-                }, function(err) {
+                }, function (err) {
                     expect(fire).not.toHaveBeenCalled();
-                    expect(''+err).toContain('No platforms added to this project. Please use `cordova platform add <platform>`.');
+                    expect('' + err).toContain('No platforms added to this project. Please use `cordova platform add <platform>`.');
                 }).fin(done);
             });
         });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/lazy_load.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/lazy_load.spec.js b/spec/cordova/lazy_load.spec.js
index 76fbecf..a4ede0d 100644
--- a/spec/cordova/lazy_load.spec.js
+++ b/spec/cordova/lazy_load.spec.js
@@ -17,53 +17,51 @@
     under the License.
 */
 
-/* jshint sub:true */
+var lazy_load = require('../../src/cordova/lazy_load');
+var npmHelper = require('../../src/util/npm-helper');
+var config = require('../../src/cordova/config');
+var shell = require('shelljs');
+var npm = require('npm');
+var path = require('path');
+var HooksRunner = require('../../src/hooks/HooksRunner');
+var request = require('request');
+var fs = require('fs');
+var Q = require('q');
+var platforms = require('../../src/platforms/platforms');
 
-var lazy_load = require('../../src/cordova/lazy_load'),
-    npmHelper = require('../../src/util/npm-helper'),
-    config = require('../../src/cordova/config'),
-    shell = require('shelljs'),
-    npm = require('npm'),
-    path = require('path'),
-    HooksRunner = require('../../src/hooks/HooksRunner'),
-    request = require('request'),
-    fs = require('fs'),
-    Q = require('q'),
-    platforms = require('../../src/platforms/platforms');
-
-describe('lazy_load module', function() {
+describe('lazy_load module', function () {
     var custom_path, cachePackage, fakeLazyLoad;
-    beforeEach(function() {
+    beforeEach(function () {
         custom_path = spyOn(config, 'has_custom_path').and.returnValue(false);
         cachePackage = spyOn(npmHelper, 'cachePackage').and.returnValue(Q(path.join('lib', 'dir')));
         fakeLazyLoad = function (id, platform, version) {
-            if (platform == 'wp7' || platform == 'wp8') {
+            if (platform === 'wp7' || platform === 'wp8') {
                 return Q(path.join('lib', 'wp', id, version, platform));
             } else {
                 return Q(path.join('lib', platform, id, version, platforms[platform] && platforms[platform].subdirectory ? platforms[platform].subdirectory : ''));
             }
         };
     });
-    describe('cordova method (loads stock cordova libs)', function() {
-        var custom,
-            version;
-        beforeEach(function() {
-            custom = spyOn(lazy_load, 'custom').and.returnValue(Q(path.join('lib','dir')));
+    describe('cordova method (loads stock cordova libs)', function () {
+        var custom; // eslint-disable-line no-unused-vars
+        var version;
+        beforeEach(function () {
+            custom = spyOn(lazy_load, 'custom').and.returnValue(Q(path.join('lib', 'dir')));
             version = platforms.android.version;
             platforms.android.version = '3.14.15.9265';
         });
         afterEach(function () {
             platforms.android.version = version;
         });
-        it('Test 001: should throw if platform is not a stock cordova platform', function(done) {
-            lazy_load.cordova('atari').then(function() {
+        it('Test 001: should throw if platform is not a stock cordova platform', function (done) {
+            lazy_load.cordova('atari').then(function () {
                 expect('this call').toEqual('to fail');
-            }, function(err) {
+            }, function (err) {
                 expect('' + err).toContain('Cordova library "atari" not recognized.');
             }).fin(done);
         });
-        it('Test 002 : should invoke lazy_load.custom with appropriate url, platform, and version as specified in platforms manifest', function(done) {
-            lazy_load.cordova('android').then(function(dir) {
+        it('Test 002 : should invoke lazy_load.custom with appropriate url, platform, and version as specified in platforms manifest', function (done) {
+            lazy_load.cordova('android').then(function (dir) {
                 expect(cachePackage).toHaveBeenCalled();
                 expect(dir).toBeDefined();
                 done();
@@ -71,9 +69,15 @@ describe('lazy_load module', function() {
         });
     });
 
-    describe('custom method (loads custom cordova libs)', function() {
-        var exists, fire, rm, mv, readdir;
-        beforeEach(function() {
+    describe('custom method (loads custom cordova libs)', function () {
+        /* eslint-disable no-unused-vars */
+        var exists;
+        var fire;
+        var rm;
+        var mv;
+        var readdir;
+        /* eslint-enable no-unused-vars */
+        beforeEach(function () {
             spyOn(shell, 'mkdir');
             rm = spyOn(shell, 'rm');
             mv = spyOn(shell, 'mv');
@@ -82,7 +86,7 @@ describe('lazy_load module', function() {
             fire = spyOn(HooksRunner, 'fire').and.returnValue(Q());
         });
 
-        it('Test 003 : should callback with no errors and not fire event hooks if library already exists', function(done) {
+        it('Test 003 : should callback with no errors and not fire event hooks if library already exists', function (done) {
             exists.and.returnValue(true);
             var mock_platforms = {
                 'platform X': {
@@ -91,13 +95,13 @@ describe('lazy_load module', function() {
                     version: 'three point five'
                 }
             };
-            lazy_load.custom(mock_platforms, 'platform X').then(function() {
+            lazy_load.custom(mock_platforms, 'platform X').then(function () {
                 expect(fire).not.toHaveBeenCalled();
-            }, function(err) {
+            }, function (err) {
                 expect(err).not.toBeDefined();
             }).fin(done);
         });
-        it('Test 004 : should callback with no errors and fire event hooks even if library already exists if the lib url is a local dir', function(done) {
+        it('Test 004 : should callback with no errors and fire event hooks even if library already exists if the lib url is a local dir', function (done) {
             exists.and.returnValue(true);
             var mock_platforms = {
                 'platform X': {
@@ -106,39 +110,39 @@ describe('lazy_load module', function() {
                     version: 'three point six'
                 }
             };
-            lazy_load.custom(mock_platforms, 'platform X').then(function() {
+            lazy_load.custom(mock_platforms, 'platform X').then(function () {
                 expect(fire).not.toHaveBeenCalled();
-            }, function(err) {
+            }, function (err) {
                 expect(err).not.toBeDefined();
             }).fin(done);
         });
 
-        describe('remote URLs for libraries', function() {
-            var req,
-                events = {},
-                fakeRequest = {
-                    on: jasmine.createSpy().and.callFake(function(event, cb) {
-                        events[event] = cb;
-                        return fakeRequest;
-                    }),
-                    pipe: jasmine.createSpy().and.callFake(function() { return fakeRequest; })
-                };
-            beforeEach(function() {
+        describe('remote URLs for libraries', function () {
+            var req;
+            var events = {};
+            var fakeRequest = {
+                on: jasmine.createSpy().and.callFake(function (event, cb) {
+                    events[event] = cb;
+                    return fakeRequest;
+                }),
+                pipe: jasmine.createSpy().and.callFake(function () { return fakeRequest; })
+            };
+            beforeEach(function () {
                 events = {};
                 fakeRequest.on.calls.reset();
                 fakeRequest.pipe.calls.reset();
-                req = spyOn(request, 'get').and.callFake(function() {
+                req = spyOn(request, 'get').and.callFake(function () {
                     // Fire the 'end' event shortly.
-                    setTimeout(function() {
+                    setTimeout(function () {
                         events['end']();
                     }, 10);
                     return fakeRequest;
                 });
-                spyOn(npm, 'load').and.callFake(function(cb) { cb(); });
+                spyOn(npm, 'load').and.callFake(function (cb) { cb(); });
                 spyOn(npm.config, 'get').and.returnValue(null);
             });
 
-            it('Test 005 : should call request with appropriate url params', function(done) {
+            it('Test 005 : should call request with appropriate url params', function (done) {
                 var url = 'https://github.com/apache/someplugin';
                 var with_android_platform = {
                     'android': {
@@ -147,15 +151,15 @@ describe('lazy_load module', function() {
                         version: '1.0'
                     }
                 };
-                lazy_load.custom(with_android_platform, 'android').then(function() {
+                lazy_load.custom(with_android_platform, 'android').then(function () {
                     expect(req).toHaveBeenCalledWith({
-                        url:url
+                        url: url
                     }, jasmine.any(Function));
-                }, function(err) {
+                }, function (err) {
                     expect(err).not.toBeDefined();
                 }).fin(done);
             });
-            it('Test 006 : should take into account https-proxy npm configuration var if exists for https:// calls', function(done) {
+            it('Test 006 : should take into account https-proxy npm configuration var if exists for https:// calls', function (done) {
                 var proxy = 'https://somelocalproxy.com';
                 npm.config.get.and.returnValue(proxy);
                 var url = 'https://github.com/apache/someplugin';
@@ -166,16 +170,16 @@ describe('lazy_load module', function() {
                         version: '1.0'
                     }
                 };
-                lazy_load.custom(with_android_platform, 'android').then(function() {
+                lazy_load.custom(with_android_platform, 'android').then(function () {
                     expect(req).toHaveBeenCalledWith({
-                        url:url,
-                        proxy:proxy
+                        url: url,
+                        proxy: proxy
                     }, jasmine.any(Function));
-                }, function(err) {
+                }, function (err) {
                     expect(err).not.toBeDefined();
                 }).fin(done);
             });
-            it('Test 007 : should take into account proxy npm config var if exists for http:// calls', function(done) {
+            it('Test 007 : should take into account proxy npm config var if exists for http:// calls', function (done) {
                 var proxy = 'http://somelocalproxy.com';
                 npm.config.get.and.returnValue(proxy);
                 var url = 'http://github.com/apache/someplugin';
@@ -186,19 +190,19 @@ describe('lazy_load module', function() {
                         version: '1.0'
                     }
                 };
-                lazy_load.custom(with_android_platform, 'android').then(function() {
+                lazy_load.custom(with_android_platform, 'android').then(function () {
                     expect(req).toHaveBeenCalledWith({
-                        url:url,
-                        proxy:proxy
+                        url: url,
+                        proxy: proxy
                     }, jasmine.any(Function));
-                }, function(err) {
+                }, function (err) {
                     expect(err).not.toBeDefined();
                 }).fin(done);
             });
         });
 
-        describe('local paths for libraries', function() {
-            it('Test 009 : should return the local path, no symlink', function(done) {
+        describe('local paths for libraries', function () {
+            it('Test 009 : should return the local path, no symlink', function (done) {
                 var mock_platforms = {
                     'X': {
                         id: 'id',
@@ -206,13 +210,13 @@ describe('lazy_load module', function() {
                         version: 'three point eight'
                     }
                 };
-                lazy_load.custom(mock_platforms, 'X').then(function(dir) {
+                lazy_load.custom(mock_platforms, 'X').then(function (dir) {
                     expect(path.normpath(dir)).toEqual('/some/random/lib');
-                }, function(err) {
+                }, function (err) {
                     expect(err).toBeUndefined();
                 }).fin(done);
             });
-            it('Test 010 : should not file download hook', function(done) {
+            it('Test 010 : should not file download hook', function (done) {
                 var mock_platforms = {
                     'X': {
                         id: 'id',
@@ -220,28 +224,30 @@ describe('lazy_load module', function() {
                         version: 'three point nine'
                     }
                 };
-                lazy_load.custom(mock_platforms, 'X').then(function() {
-                    expect(fire).not.toHaveBeenCalledWith('after_library_download', {platform:'X',url:'/some/random/lib',id:'id',version:'three point nine',path:'/some/random/lib', symlink:false});
-                }, function(err) {
+                lazy_load.custom(mock_platforms, 'X').then(function () {
+                    expect(fire).not.toHaveBeenCalledWith('after_library_download', {platform: 'X', url: '/some/random/lib', id: 'id', version: 'three point nine', path: '/some/random/lib', symlink: false});
+                }, function (err) {
                     expect(err).toBeUndefined();
                 }).fin(done);
             });
         });
     });
 
-    describe('based_on_config method', function() {
-        var cordova, custom, read;
-        beforeEach(function() {
+    describe('based_on_config method', function () {
+        var cordova;
+        var custom;
+        var read; // eslint-disable-line no-unused-vars
+        beforeEach(function () {
             cordova = spyOn(lazy_load, 'cordova').and.returnValue(Q());
             custom = spyOn(lazy_load, 'custom').and.returnValue(Q());
         });
-        it('Test 011 : should invoke custom if a custom lib is specified', function(done) {
+        it('Test 011 : should invoke custom if a custom lib is specified', function (done) {
             read = spyOn(config, 'read').and.returnValue({
-                lib:{
-                    maybe:{
-                        url:'you or eye?',
-                        id:'eye dee',
-                        version:'four point twenty'
+                lib: {
+                    maybe: {
+                        url: 'you or eye?',
+                        id: 'eye dee',
+                        version: 'four point twenty'
                     }
                 }
             });
@@ -254,16 +260,16 @@ describe('lazy_load module', function() {
                 expect(platforms[platform].version).toEqual('four point twenty');
                 return fakeLazyLoad(platforms[platform].id, platform, platforms[platform].version);
             });
-            lazy_load.based_on_config('yup', 'maybe').then(function() {
+            lazy_load.based_on_config('yup', 'maybe').then(function () {
                 expect(custom).toHaveBeenCalled();
-            }, function(err) {
+            }, function (err) {
                 expect(err).toBeUndefined();
             }).fin(done);
         });
-        it('Test 012 : should invoke cordova if no custom lib is specified', function(done) {
-            lazy_load.based_on_config('yup', 'ios').then(function() {
+        it('Test 012 : should invoke cordova if no custom lib is specified', function (done) {
+            lazy_load.based_on_config('yup', 'ios').then(function () {
                 expect(cordova).toHaveBeenCalled();
-            }, function(err) {
+            }, function (err) {
                 expect(err).toBeUndefined();
             }).fin(done);
         });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/blackberry_parser.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/blackberry_parser.spec.js b/spec/cordova/metadata/blackberry_parser.spec.js
index abca94a..6bb0bf9 100644
--- a/spec/cordova/metadata/blackberry_parser.spec.js
+++ b/spec/cordova/metadata/blackberry_parser.spec.js
@@ -17,16 +17,16 @@
     under the License.
 */
 
-var blackberryParser = require('../../../src/cordova/metadata/blackberry10_parser'),
-    util = require('../../../src/cordova/util'),
-    path = require('path'),
-    shell = require('shelljs'),
-    fs = require('fs'),
-    et = require('elementtree'),
-    xmlHelpers = require('cordova-common').xmlHelpers,
-    config = require('../../../src/cordova/config'),
-    Parser = require('../../../src/cordova/metadata/parser'),
-    ConfigParser = require('cordova-common').ConfigParser;
+var blackberryParser = require('../../../src/cordova/metadata/blackberry10_parser');
+var util = require('../../../src/cordova/util');
+var path = require('path');
+var shell = require('shelljs');
+var fs = require('fs');
+var et = require('elementtree');
+var xmlHelpers = require('cordova-common').xmlHelpers;
+var config = require('../../../src/cordova/config');
+var Parser = require('../../../src/cordova/metadata/parser');
+var ConfigParser = require('cordova-common').ConfigParser;
 
 var cfg = new ConfigParser(path.join(__dirname, '..', 'test-config.xml'));
 
@@ -48,59 +48,68 @@ var TEST_XML = '<?xml version="1.0" encoding="UTF-8"?>\n' +
     '    <preference name="webviewbounce" value="true" />\n' +
     '</widget>\n';
 
-describe('blackberry10 project parser', function() {
+describe('blackberry10 project parser', function () {
     var proj = '/some/path';
-    var exists, custom;
-    beforeEach(function() {
+    var exists;
+    var custom; // eslint-disable-line no-unused-vars
+    beforeEach(function () {
         exists = spyOn(fs, 'existsSync').and.returnValue(true);
         custom = spyOn(config, 'has_custom_path').and.returnValue(false);
         spyOn(ConfigParser.prototype, 'write');
-        spyOn(xmlHelpers, 'parseElementtreeSync').and.callFake(function() {
+        spyOn(xmlHelpers, 'parseElementtreeSync').and.callFake(function () {
             return new et.ElementTree(et.XML(TEST_XML));
         });
     });
 
-    function wrapper(p, done, post) {
-        p.then(post, function(err) {
+    function wrapper (p, done, post) {
+        p.then(post, function (err) {
             expect(err).toBeUndefined();
         }).fin(done);
     }
 
-    function errorWrapper(p, done, post) {
-        p.then(function() {
+    function errorWrapper (p, done, post) {
+        p.then(function () {
             expect('this call').toBe('fail');
         }, post).fin(done);
     }
 
-    describe('constructions', function() {
-        it('should throw an exception with a path that is not a native blackberry project', function() {
+    describe('constructions', function () {
+        it('should throw an exception with a path that is not a native blackberry project', function () {
             exists.and.returnValue(false);
-            expect(function() {
-                new blackberryParser(proj);
+            expect(function () {
+                new blackberryParser(proj); // eslint-disable-line
             }).toThrow();
         });
-        it('should accept a proper native blackberry project path as construction parameter', function() {
+        it('should accept a proper native blackberry project path as construction parameter', function () {
             var project;
-            expect(function() {
-                project = new blackberryParser(proj);
+            expect(function () {
+                project = new blackberryParser(proj); // eslint-disable-line
             }).not.toThrow();
             expect(project).toBeDefined();
         });
-        it('should be an instance of Parser', function() {
-            expect(new blackberryParser(proj) instanceof Parser).toBe(true);
+        it('should be an instance of Parser', function () {
+            expect(new blackberryParser(proj) instanceof Parser).toBe(true); // eslint-disable-line
         });
-        it('should call super with the correct arguments', function() {
+        it('should call super with the correct arguments', function () {
             var call = spyOn(Parser, 'call');
-            var p = new blackberryParser(proj);
+            var p = new blackberryParser(proj); // eslint-disable-line
             expect(call).toHaveBeenCalledWith(p, 'blackberry10', proj);
         });
     });
 
-    describe('instance', function() {
-        var p, cp, rm, mkdir, is_cordova, write, read;
+    describe('instance', function () {
+        /* eslint-disable no-unused-vars */
+        var p;
+        var cp;
+        var rm;
+        var mkdir;
+        var is_cordova;
+        var write;
+        var read;
         var bb_proj = path.join(proj, 'platforms', 'blackberry10');
-        beforeEach(function() {
-            p = new blackberryParser(bb_proj);
+        /* eslint-enable no-unused-vars */
+        beforeEach(function () {
+            p = new blackberryParser(bb_proj); // eslint-disable-line
             cp = spyOn(shell, 'cp');
             rm = spyOn(shell, 'rm');
             mkdir = spyOn(shell, 'mkdir');
@@ -109,11 +118,11 @@ describe('blackberry10 project parser', function() {
             read = spyOn(fs, 'readFileSync');
         });
 
-        describe('update_from_config method', function() {
+        describe('update_from_config method', function () {
             var xml_name, xml_pkg, xml_version, xml_access_rm, xml_update,
                 xml_append, xml_content, xml_access_add, xml_preference_remove,
                 xml_preference_add;
-            beforeEach(function() {
+            beforeEach(function () {
                 xml_content = jasmine.createSpy('xml content');
                 xml_name = jasmine.createSpy('xml name');
                 xml_pkg = jasmine.createSpy('xml pkg');
@@ -129,84 +138,90 @@ describe('blackberry10 project parser', function() {
                 p.xml.version = xml_version;
                 p.xml.content = xml_content;
                 p.xml.access = {
-                    remove:xml_access_rm,
+                    remove: xml_access_rm,
                     add: xml_access_add
                 };
                 p.xml.update = xml_update;
                 p.xml.doc = {
-                    getroot:function() { return { append:xml_append}; }
+                    getroot: function () { return { append: xml_append }; }
                 };
                 p.xml.preference = {
                     add: xml_preference_add,
                     remove: xml_preference_remove
                 };
-                cfg.name = function() { return 'testname'; };
-                cfg.packageName = function() { return 'testpkg'; };
-                cfg.version = function() { return 'one point oh'; };
+                cfg.name = function () { return 'testname'; };
+                cfg.packageName = function () { return 'testpkg'; };
+                cfg.version = function () { return 'one point oh'; };
             });
         });
-        describe('www_dir method', function() {
-            it('should return /www', function() {
+        describe('www_dir method', function () {
+            it('should return /www', function () {
                 expect(p.www_dir()).toEqual(path.join(bb_proj, 'www'));
             });
         });
-        describe('config_xml method', function() {
-            it('should return the location of the config.xml', function() {
+        describe('config_xml method', function () {
+            it('should return the location of the config.xml', function () {
                 expect(p.config_xml()).toEqual(path.join(proj, 'platforms', 'blackberry10', 'www', 'config.xml'));
             });
         });
-        describe('update_www method', function() {
+        describe('update_www method', function () {
 
-            it('should rm project-level www and cp in platform agnostic www', function() {
+            it('should rm project-level www and cp in platform agnostic www', function () {
                 p.update_www();
                 expect(rm).toHaveBeenCalled();
                 expect(cp).toHaveBeenCalled();
             });
         });
-        describe('update_overrides method', function() {
-            it('should do nothing if merges directory does not exist', function() {
+        describe('update_overrides method', function () {
+            it('should do nothing if merges directory does not exist', function () {
                 exists.and.returnValue(false);
                 p.update_overrides();
                 expect(cp).not.toHaveBeenCalled();
             });
-            it('should copy merges path into www', function() {
+            it('should copy merges path into www', function () {
                 p.update_overrides();
                 expect(cp).toHaveBeenCalledWith('-rf', path.join(proj, 'merges', 'blackberry10', '*'), path.join(proj, 'platforms', 'blackberry10', 'www'));
             });
         });
-        describe('update_project method', function() {
-            var config, www, overrides, svn, parse;
-            beforeEach(function() {
+        describe('update_project method', function () {
+            /* eslint-disable no-unused-vars */
+            var config;
+            var www;
+            var overrides;
+            var svn;
+            var parse;
+            /* eslint-enable no-unused-vars */
+            beforeEach(function () {
                 config = spyOn(p, 'update_from_config');
                 www = spyOn(p, 'update_www');
                 overrides = spyOn(p, 'update_overrides');
                 svn = spyOn(util, 'deleteSvnFolders');
-                parse = spyOn(JSON, 'parse').and.returnValue({blackberry:{qnx:{}}});
+                parse = spyOn(JSON, 'parse').and.returnValue({blackberry: {qnx: {}}});
             });
-            it('should call update_from_config', function(done) {
-                wrapper(p.update_project(), done, function() {
+            it('should call update_from_config', function (done) {
+                wrapper(p.update_project(), done, function () {
                     expect(config).toHaveBeenCalled();
                 });
             });
-            it('should throw if update_from_config throws', function(done) {
+            it('should throw if update_from_config throws', function (done) {
                 var err = new Error('uh oh!');
-                config.and.callFake(function() { throw err; });
-                errorWrapper(p.update_project({}), done, function(e) {
+                config.and.callFake(function () { throw err; });
+                errorWrapper(p.update_project({}), done, function (e) {
                     expect(e).toEqual(err);
                 });
             });
-            it('should not call update_www', function(done) {
-                wrapper(p.update_project(), done, function() {
+            it('should not call update_www', function (done) {
+                wrapper(p.update_project(), done, function () {
                     expect(www).not.toHaveBeenCalled();
                 });
             });
-            it('should call update_overrides', function(done) {
-                wrapper(p.update_project(), done, function() {
+            it('should call update_overrides', function (done) {
+                wrapper(p.update_project(), done, function () {
                     expect(overrides).toHaveBeenCalled();
                 });
             });
-            it('should call deleteSvnFolders', function(done) {
-                wrapper(p.update_project(), done, function() {
+            it('should call deleteSvnFolders', function (done) {
+                wrapper(p.update_project(), done, function () {
                     expect(svn).toHaveBeenCalled();
                 });
             });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/browser_parser.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/browser_parser.spec.js b/spec/cordova/metadata/browser_parser.spec.js
index f743706..8f94c0e 100644
--- a/spec/cordova/metadata/browser_parser.spec.js
+++ b/spec/cordova/metadata/browser_parser.spec.js
@@ -17,79 +17,83 @@
     under the License.
 */
 
-var browserParser = require('../../../src/cordova/metadata/browser_parser'),
-    util = require('../../../src/cordova/util'),
-    path = require('path'),
-    shell = require('shelljs'),
-    fs = require('fs'),
-    Parser = require('../../../src/cordova/metadata/parser');
+var browserParser = require('../../../src/cordova/metadata/browser_parser');
+var util = require('../../../src/cordova/util');
+var path = require('path');
+var shell = require('shelljs');
+var fs = require('fs');
+var Parser = require('../../../src/cordova/metadata/parser');
 
-describe('browser project parser', function() {
+describe('browser project parser', function () {
     var proj = path.join('some', 'path');
     var exists;
 
-    beforeEach(function() {
+    beforeEach(function () {
         exists = spyOn(fs, 'existsSync').and.returnValue(true);
-        spyOn(browserParser,'dirExists').and.returnValue(true);
+        spyOn(browserParser, 'dirExists').and.returnValue(true);
     });
 
-    describe('constructions', function() {
-        it('should create an instance with a path', function() {
-            expect(function() {
-                var p = new browserParser(proj);
+    describe('constructions', function () {
+        it('should create an instance with a path', function () {
+            expect(function () {
+                var p = new browserParser(proj); // eslint-disable-line new-cap
                 expect(p.path).toEqual(proj);
             }).not.toThrow();
         });
-        it('should be an instance of Parser', function() {
-            expect(new browserParser(proj) instanceof Parser).toBe(true);
+        it('should be an instance of Parser', function () {
+            expect(new browserParser(proj) instanceof Parser).toBe(true); // eslint-disable-line new-cap
         });
-        it('should call super with the correct arguments', function() {
+        it('should call super with the correct arguments', function () {
             var call = spyOn(Parser, 'call');
-            var p = new browserParser(proj);
+            var p = new browserParser(proj); // eslint-disable-line new-cap
             expect(call).toHaveBeenCalledWith(p, 'browser', proj);
         });
     });
 
-    describe('instance', function() {
-        var p, cp, rm, mkdir, is_cordova;
+    describe('instance', function () {
+        var p;
+        var cp;
+        var rm;
+        var mkdir; // eslint-disable-line no-unused-vars
+        var is_cordova; // eslint-disable-line no-unused-vars
         var browser_proj = path.join(proj, 'platforms', 'browser');
 
-        beforeEach(function() {
-            p = new browserParser(browser_proj);
+        beforeEach(function () {
+            p = new browserParser(browser_proj); // eslint-disable-line new-cap
             cp = spyOn(shell, 'cp');
             rm = spyOn(shell, 'rm');
             mkdir = spyOn(shell, 'mkdir');
             is_cordova = spyOn(util, 'isCordova').and.returnValue(proj);
         });
 
-        describe('www_dir method', function() {
-            it('should return /www', function() {
+        describe('www_dir method', function () {
+            it('should return /www', function () {
                 expect(p.www_dir()).toEqual(path.join(browser_proj, 'www'));
             });
         });
 
-        describe('config_xml method', function() {
-            it('should return the location of config.xml', function() {
+        describe('config_xml method', function () {
+            it('should return the location of config.xml', function () {
                 expect(p.config_xml()).toEqual(path.join(proj, 'platforms', 'browser', 'config.xml'));
             });
         });
 
-        describe('update_www method', function() {
-            it('should rm project-level www and cp in platform agnostic www', function() {
+        describe('update_www method', function () {
+            it('should rm project-level www and cp in platform agnostic www', function () {
                 p.update_www();
                 expect(rm).toHaveBeenCalled();
                 expect(cp).toHaveBeenCalled();
             });
         });
 
-        describe('update_overrides method', function() {
-            it('should do nothing if merges directory does not exist', function() {
+        describe('update_overrides method', function () {
+            it('should do nothing if merges directory does not exist', function () {
                 exists.and.returnValue(false);
                 p.update_overrides();
                 expect(cp).not.toHaveBeenCalled();
             });
 
-            it('should copy merges path into www', function() {
+            it('should copy merges path into www', function () {
                 p.update_overrides();
                 expect(cp).toHaveBeenCalledWith('-rf', path.join(proj, 'merges', 'browser', '*'), path.join(proj, 'platforms', 'browser', 'www'));
             });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/parser.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/parser.spec.js b/spec/cordova/metadata/parser.spec.js
index 89861f6..5b2ace4 100644
--- a/spec/cordova/metadata/parser.spec.js
+++ b/spec/cordova/metadata/parser.spec.js
@@ -17,33 +17,34 @@
     under the License.
 */
 
-var fs = require('fs'),
-    Parser = require('../../../src/cordova/metadata/parser'),
-    ParserHelper = require('../../../src/cordova/metadata/parserhelper/ParserHelper');
+var fs = require('fs');
+var Parser = require('../../../src/cordova/metadata/parser');
+var ParserHelper = require('../../../src/cordova/metadata/parserhelper/ParserHelper');
 
-describe('base parser', function() {
+describe('base parser', function () {
 
-    var exists, parser;
+    var exists; // eslint-disable-line no-unused-vars
+    var parser;
 
-    beforeEach(function() {
+    beforeEach(function () {
         exists = spyOn(fs, 'existsSync');
         parser = new Parser();
     });
 
-    describe('properties', function() {
+    describe('properties', function () {
 
-        it('should have properties named path and platform', function() {
+        it('should have properties named path and platform', function () {
             expect(parser.path).not.toBeUndefined();
             expect(parser.platform).not.toBeUndefined();
         });
 
-        it('should have a property named helper that is an instace of ParserHelper', function() {
+        it('should have a property named helper that is an instace of ParserHelper', function () {
             var descriptor = Object.getOwnPropertyDescriptor(parser, 'helper');
             expect(descriptor).not.toBeUndefined();
             expect(descriptor.value instanceof ParserHelper).toBe(true);
         });
 
-        it('should have an immutable helper property', function() {
+        it('should have an immutable helper property', function () {
             var value = 'foo';
             parser.helpers = value;
             expect(parser.helper instanceof ParserHelper).toBe(true);

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/parserhelper/ParserHelper.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/parserhelper/ParserHelper.spec.js b/spec/cordova/metadata/parserhelper/ParserHelper.spec.js
index f495e6f..2761539 100644
--- a/spec/cordova/metadata/parserhelper/ParserHelper.spec.js
+++ b/spec/cordova/metadata/parserhelper/ParserHelper.spec.js
@@ -17,19 +17,19 @@
     under the License.
 */
 
-var path = require('path'),
-    ParserHelper = require('../../../../src/cordova/metadata/parserhelper/ParserHelper'),
-    ConfigParser = require('cordova-common').ConfigParser;
+var path = require('path');
+var ParserHelper = require('../../../../src/cordova/metadata/parserhelper/ParserHelper');
+var ConfigParser = require('cordova-common').ConfigParser;
 
 // Create a real config object before mocking out everything.
 var xml = path.join(__dirname, '..', '..', 'test-config.xml');
 var cfg = new ConfigParser(xml);
 
-describe('ParserHelper', function() {
+describe('ParserHelper', function () {
 
-    describe('constructions', function() {
+    describe('constructions', function () {
 
-        it('should pass platform name as a constructor parameter', function() {
+        it('should pass platform name as a constructor parameter', function () {
             var ph = new ParserHelper();
             expect(ph.platform).toEqual('');
             ph = new ParserHelper('some-platform');
@@ -38,20 +38,20 @@ describe('ParserHelper', function() {
 
     });
 
-    describe('instance', function() {
+    describe('instance', function () {
 
         var parserHelper;
 
-        beforeEach(function() {
+        beforeEach(function () {
             parserHelper = new ParserHelper();
         });
 
-        describe('getOrientation method', function() {
+        describe('getOrientation method', function () {
 
-            it('should return the global orientation value', function() {
+            it('should return the global orientation value', function () {
                 expect(parserHelper.getOrientation(cfg)).toEqual('portrait');
             });
-            it('should return the platform-specific orientation value', function() {
+            it('should return the platform-specific orientation value', function () {
                 var parserHelperAndroid = new ParserHelper('android');
                 expect(parserHelperAndroid.getOrientation(cfg)).toEqual('landscape');
             });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/parserhelper/preferences.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/parserhelper/preferences.spec.js b/spec/cordova/metadata/parserhelper/preferences.spec.js
index 0fef703..73dc0b9 100644
--- a/spec/cordova/metadata/parserhelper/preferences.spec.js
+++ b/spec/cordova/metadata/parserhelper/preferences.spec.js
@@ -17,26 +17,26 @@
     under the License.
 */
 
-var path = require('path'),
-    fs = require('fs'),
-    events = require('cordova-common').events,
-    preferences = require('../../../../src/cordova/metadata/parserhelper/preferences'),
-    ConfigParser = require('cordova-common').ConfigParser;
+var path = require('path');
+var fs = require('fs');
+var events = require('cordova-common').events;
+var preferences = require('../../../../src/cordova/metadata/parserhelper/preferences');
+var ConfigParser = require('cordova-common').ConfigParser;
 
 // Create a real config object before mocking out everything.
 var xml = path.join(__dirname, '..', '..', 'test-config.xml');
 var cfg = new ConfigParser(xml);
 
-describe('preferences', function() {
+describe('preferences', function () {
 
-    describe('properties', function() {
+    describe('properties', function () {
 
-        it('should define global orientation constants', function() {
+        it('should define global orientation constants', function () {
             expect(preferences.ORIENTATION_DEFAULT).toEqual('default');
             expect(preferences.ORIENTATION_PORTRAIT).toEqual('portrait');
             expect(preferences.ORIENTATION_LANDSCAPE).toEqual('landscape');
             expect(preferences.ORIENTATION_ALL).toEqual('all');
-            
+
             expect(preferences.ORIENTATION_GLOBAL_ORIENTATIONS).toEqual([ 'default', 'portrait', 'landscape' ]);
             expect(preferences.ORIENTATION_SPECIFIC_TO_A_PLATFORM_ORIENTATIONS.ios).toEqual([ 'all' ]);
             expect(preferences.ORIENTATION_SPECIFIC_TO_A_PLATFORM_ORIENTATIONS.foobar).toBeUndefined();
@@ -44,87 +44,87 @@ describe('preferences', function() {
 
     });
 
-    describe('methods', function() {
+    describe('methods', function () {
 
         var readFile, emit;
 
-        beforeEach(function() {
+        beforeEach(function () {
             readFile = spyOn(fs, 'readFileSync');
             emit = spyOn(events, 'emit');
         });
 
-        describe('isDefaultOrientation', function() {
+        describe('isDefaultOrientation', function () {
 
-            it('should return true if an orientation is the default orientation', function() {
+            it('should return true if an orientation is the default orientation', function () {
                 expect(preferences.isDefaultOrientation('default')).toBe(true);
             });
-            it('should return false if an orientation is not the default orientation', function() {
+            it('should return false if an orientation is not the default orientation', function () {
                 expect(preferences.isDefaultOrientation('some-orientation')).toBe(false);
             });
 
         });
 
-        describe('isGlobalOrientation', function() {
+        describe('isGlobalOrientation', function () {
 
-            it('should return true if an orientation is a global orientation', function() {
+            it('should return true if an orientation is a global orientation', function () {
                 expect(preferences.isGlobalOrientation('portrait')).toBe(true);
             });
-            it('should return false if an orientation is a global orientation', function() {
+            it('should return false if an orientation is a global orientation', function () {
                 expect(preferences.isGlobalOrientation('some-orientation')).toBe(false);
             });
 
         });
-        
-        describe('isOrientationSpecificToAPlatform', function() {
 
-            it('should return true if an orientation is specific to a platform', function() {
+        describe('isOrientationSpecificToAPlatform', function () {
+
+            it('should return true if an orientation is specific to a platform', function () {
                 expect(preferences.isOrientationSpecificToAPlatform('all', 'ios')).toBe(true);
                 expect(preferences.isOrientationSpecificToAPlatform('sensorLandscape', 'android')).toBe(true);
-                
+
             });
-            it('should return false if an orientation is not a specific to a platform', function() {
+            it('should return false if an orientation is not a specific to a platform', function () {
                 expect(preferences.isOrientationSpecificToAPlatform('some-orientation', 'foobar')).toBe(false);
             });
 
         });
 
-        describe('getOrientation', function() {
+        describe('getOrientation', function () {
 
-            it('should handle no platform', function() {
+            it('should handle no platform', function () {
                 expect(preferences.getOrientation(cfg)).toEqual('portrait');
                 expect(emit).not.toHaveBeenCalled();
             });
-            it('should handle undefined platform-specific orientation', function() {
+            it('should handle undefined platform-specific orientation', function () {
                 expect(preferences.getOrientation(cfg, 'ios')).toEqual('portrait');
                 expect(emit).not.toHaveBeenCalled();
             });
-            it('should handle platform-specific orientation', function() {
+            it('should handle platform-specific orientation', function () {
                 expect(preferences.getOrientation(cfg, 'android')).toEqual('landscape');
             });
-            it('should handle orientation specific to a platform', function() {
+            it('should handle orientation specific to a platform', function () {
                 var configXml, configParser;
-                
+
                 configXml = '<?xml version="1.0" encoding="UTF-8"?><widget><preference name="orientation" value="all" /></widget>';
                 readFile.and.returnValue(configXml);
                 configParser = new ConfigParser(xml);
 
                 expect(preferences.getOrientation(configParser, 'ios')).toEqual('all');
-                
+
                 configXml = '<?xml version="1.0" encoding="UTF-8"?><widget><preference name="orientation" value="sensorLandscape" /></widget>';
                 readFile.and.returnValue(configXml);
                 configParser = new ConfigParser(xml);
-                
+
                 expect(preferences.getOrientation(configParser, 'android')).toEqual('sensorLandscape');
             });
-            
-            it('should handle no orientation', function() {
+
+            it('should handle no orientation', function () {
                 var configXml = '<?xml version="1.0" encoding="UTF-8"?><widget></widget>';
                 readFile.and.returnValue(configXml);
                 var configParser = new ConfigParser(xml);
                 expect(preferences.getOrientation(configParser)).toEqual('');
                 expect(emit).not.toHaveBeenCalled();
             });
-            it('should handle invalid global orientation', function() {
+            it('should handle invalid global orientation', function () {
                 var configXml = '<?xml version="1.0" encoding="UTF-8"?><widget><preference name="orientation" value="foobar" /></widget>';
                 readFile.and.returnValue(configXml);
                 var configParser = new ConfigParser(xml);
@@ -132,8 +132,8 @@ describe('preferences', function() {
                 expect(emit).toHaveBeenCalledWith('warn', 'Unsupported global orientation: foobar');
                 expect(emit).toHaveBeenCalledWith('warn', 'Defaulting to value: default');
             });
-            
-            it('should handle custom platform-specific orientation', function() {
+
+            it('should handle custom platform-specific orientation', function () {
                 var configXml = '<?xml version="1.0" encoding="UTF-8"?><widget><platform name="some-platform"><preference name="orientation" value="foobar" /></platform></widget>';
                 readFile.and.returnValue(configXml);
                 var configParser = new ConfigParser(xml);

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/metadata/webos_parser.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/metadata/webos_parser.spec.js b/spec/cordova/metadata/webos_parser.spec.js
index 796306f..0f4091d 100755
--- a/spec/cordova/metadata/webos_parser.spec.js
+++ b/spec/cordova/metadata/webos_parser.spec.js
@@ -16,40 +16,51 @@
     specific language governing permissions and limitations
     under the License.
 */
-var webosParser = require('../../../src/cordova/metadata/webos_parser'),
-    util = require('../../../src/cordova/util'),
-    path = require('path'),
-    shell = require('shelljs'),
-    fs = require('fs'),
-    config = require('../../../src/cordova/config'),
-    ConfigParser = require('cordova-common').ConfigParser;
+var webosParser = require('../../../src/cordova/metadata/webos_parser');
+var util = require('../../../src/cordova/util');
+var path = require('path');
+var shell = require('shelljs');
+var fs = require('fs');
+var config = require('../../../src/cordova/config');
+var ConfigParser = require('cordova-common').ConfigParser;
 
 var cfg = new ConfigParser(path.join(__dirname, '..', 'test-config.xml'));
-describe('webos project parser', function() {
+describe('webos project parser', function () {
     var proj = path.join('some', 'path');
-    var exists, exec, custom;
-    beforeEach(function() {
+    /* eslint-disable no-unused-vars */
+    var exists;
+    var exec;
+    var custom;
+    /* eslint-enable no-unused-vars */
+    beforeEach(function () {
         exists = spyOn(fs, 'existsSync').and.returnValue(true);
-        exec = spyOn(shell, 'exec').and.callFake(function(cmd, opts, cb) {
-            cb(0, '');
+        exec = spyOn(shell, 'exec').and.callFake(function (cmd, opts, cb) {
+            cb(0, ''); // eslint-disable-line standard/no-callback-literal
         });
         custom = spyOn(config, 'has_custom_path').and.returnValue(false);
     });
 
-    describe('constructions', function() {
-        it('should create an instance with a path', function() {
-            expect(function() {
-                var p = new webosParser(proj);
+    describe('constructions', function () {
+        it('should create an instance with a path', function () {
+            expect(function () {
+                var p = new webosParser(proj); // eslint-disable-line new-cap
                 expect(p.path).toEqual(proj);
             }).not.toThrow();
         });
     });
 
-    describe('instance', function() {
-        var p, cp, rm, is_cordova, write, read;
+    describe('instance', function () {
+        /* eslint-disable no-unused-vars */
+        var p;
+        var cp;
+        var rm;
+        var is_cordova;
+        var write;
+        var read;
+        /* eslint-enable no-unused-vars */
         var wos_proj = path.join(proj, 'platforms', 'webos');
-        beforeEach(function() {
-            p = new webosParser(wos_proj);
+        beforeEach(function () {
+            p = new webosParser(wos_proj); // eslint-disable-line new-cap
             cp = spyOn(shell, 'cp');
             rm = spyOn(shell, 'rm');
             is_cordova = spyOn(util, 'isCordova').and.returnValue(proj);
@@ -57,17 +68,17 @@ describe('webos project parser', function() {
             read = spyOn(fs, 'readFileSync').and.returnValue('');
         });
 
-        describe('update_from_config method', function() {
-            beforeEach(function() {
-                cfg.name = function() { return 'testname'; };
-                cfg.packageName = function() { return 'testpkg'; };
-                cfg.version = function() { return '1.0'; };
+        describe('update_from_config method', function () {
+            beforeEach(function () {
+                cfg.name = function () { return 'testname'; };
+                cfg.packageName = function () { return 'testpkg'; };
+                cfg.version = function () { return '1.0'; };
             });
 
-          /*  it('should write appinfo.json', function() {
+            /*  it('should write appinfo.json', function() {
                 //p.update_from_config(cfg);
                 //expect(write.mostRecentCall.args[0]).toEqual('appinfo.json');
-            });*/
+            }); */
         });
     });
 });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/17438d2b/spec/cordova/platform/addHelper.spec.js
----------------------------------------------------------------------
diff --git a/spec/cordova/platform/addHelper.spec.js b/spec/cordova/platform/addHelper.spec.js
index b6de9b9..fc5ef40 100644
--- a/spec/cordova/platform/addHelper.spec.js
+++ b/spec/cordova/platform/addHelper.spec.js
@@ -108,8 +108,8 @@ describe('cordova/platform/addHelper', function () {
 
         it('should log if host OS does not support the specified platform', function (done) {
             cordova_util.hostSupports.and.returnValue(false);
-            platform_addHelper('add', hooks_mock, projectRoot, ['atari']).then(function() {
-        fail('addHelper success handler unexpectedly invoked');
+            platform_addHelper('add', hooks_mock, projectRoot, ['atari']).then(function () {
+                fail('addHelper success handler unexpectedly invoked');
             }).fail(function (e) {
                 expect(cordova_util.hostSupports).toHaveBeenCalled();
                 expect(events.emit).toHaveBeenCalledWith('warning', jasmine.stringMatching(/WARNING: Applications/));
@@ -125,7 +125,7 @@ describe('cordova/platform/addHelper', function () {
             }).done(done);
         });
 
-        it('should throw if platform was not added before updating', function(done) {
+        it('should throw if platform was not added before updating', function (done) {
             platform_addHelper('update', hooks_mock, projectRoot, ['atari']).then(function () {
                 fail('addHelper success handler unexpectedly invoked');
             }).fail(function (e) {
@@ -150,7 +150,7 @@ describe('cordova/platform/addHelper', function () {
             it('should retrieve platform details from directories-specified-as-platforms using getPlatformDetailsFromDir', function (done) {
                 cordova_util.isDirectory.and.returnValue(true);
                 var directory_to_platform = '/path/to/cordova-atari';
-                platform_addHelper('add', hooks_mock, projectRoot, [directory_to_platform], {restoring:true}).then(function () {
+                platform_addHelper('add', hooks_mock, projectRoot, [directory_to_platform], {restoring: true}).then(function () {
                     expect(platform_module.getPlatformDetailsFromDir).toHaveBeenCalledWith(directory_to_platform, null);
                     expect(platform_addHelper.downloadPlatform).not.toHaveBeenCalled();
                 }).fail(function (e) {
@@ -162,7 +162,7 @@ describe('cordova/platform/addHelper', function () {
             it('should retrieve platform details from URLs-specified-as-platforms using downloadPlatform', function (done) {
                 cordova_util.isUrl.and.returnValue(true);
                 var url_to_platform = 'http://github.com/apache/cordova-atari';
-                platform_addHelper('add', hooks_mock, projectRoot, [url_to_platform], {restoring:true}).then(function () {
+                platform_addHelper('add', hooks_mock, projectRoot, [url_to_platform], {restoring: true}).then(function () {
                     expect(platform_addHelper.downloadPlatform).toHaveBeenCalledWith(projectRoot, null, url_to_platform, jasmine.any(Object));
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
@@ -171,7 +171,7 @@ describe('cordova/platform/addHelper', function () {
             });
 
             it('should attempt to retrieve from config.xml if exists and package.json does not', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {restoring:true}).then(function() {
+                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {restoring: true}).then(function () {
                     expect(platform_addHelper.getVersionFromConfigFile).toHaveBeenCalled();
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
@@ -180,7 +180,7 @@ describe('cordova/platform/addHelper', function () {
             });
 
             it('should fall back to using pinned version if both package.json and config.xml do not specify it', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {restoring:true}).then(function() {
+                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {restoring: true}).then(function () {
                     expect(events.emit).toHaveBeenCalledWith('verbose', 'Grabbing pinned version.');
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
@@ -192,7 +192,7 @@ describe('cordova/platform/addHelper', function () {
                 cordova_util.isDirectory.and.returnValue(projectRoot);
                 cordova_util.fixRelativePath.and.returnValue(projectRoot);
                 spyOn(path, 'resolve').and.callThrough();
-                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save:true, fetch: true, restoring:true}).then(function() {
+                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, fetch: true, restoring: true}).then(function () {
                     expect(fetch_mock).toHaveBeenCalled();
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
@@ -204,7 +204,7 @@ describe('cordova/platform/addHelper', function () {
         describe('platform api invocation', function () {
 
             it('should invoke the createPlatform platform API method when adding a platform, providing destination location, parsed config file and platform detail options as arguments', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, fetch: true, restoring:true}).then(function(result) {
+                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, fetch: true, restoring: true}).then(function (result) {
                     expect(platform_api_mock.createPlatform).toHaveBeenCalled();
                 }).fail(function (err) {
                     fail('unexpected failure handler invoked!');
@@ -212,10 +212,10 @@ describe('cordova/platform/addHelper', function () {
                 }).done(done);
             });
 
-            it('should invoke the update platform API method when updating a platform, providing destination location and plaform detail options as arguments', function(done) {
+            it('should invoke the update platform API method when updating a platform, providing destination location and plaform detail options as arguments', function (done) {
                 cordova_util.isDirectory.and.returnValue(true);
                 fs.existsSync.and.returnValue(true);
-                platform_addHelper('update', hooks_mock, projectRoot, ['ios'], {restoring:true}).then(function(result) {
+                platform_addHelper('update', hooks_mock, projectRoot, ['ios'], {restoring: true}).then(function (result) {
                     expect(platform_api_mock.updatePlatform).toHaveBeenCalled();
                 }).fail(function (err) {
                     fail('unexpected failure handler invoked!');
@@ -229,7 +229,7 @@ describe('cordova/platform/addHelper', function () {
             describe('when the restoring option is not provided', function () {
                 // test is commented out b/c preparePlatforms can't be spied on as it is dynamically required due to circular references.
                 xit('should invoke preparePlatforms twice (?!?), once before installPluginsForNewPlatforms and once after... ?!', function (done) {
-                    platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true}).then(function(result) {
+                    platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true}).then(function (result) {
                         expect(prepare.preparePlatforms).toHaveBeenCalledWith([ 'atari' ], '/some/path', Object({ searchpath: undefined }));
                     }).fail(function (err) {
                         fail('unexpected failure handler invoked!');
@@ -239,7 +239,7 @@ describe('cordova/platform/addHelper', function () {
             });
 
             it('should invoke the installPluginsForNewPlatforms method in the platform-add case', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true, restoring:true}).then(function(result) {
+                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true, restoring: true}).then(function (result) {
                     expect(platform_addHelper.installPluginsForNewPlatform).toHaveBeenCalled();
                 }).fail(function (err) {
                     fail('unexpected failure handler invoked!');
@@ -248,7 +248,7 @@ describe('cordova/platform/addHelper', function () {
             });
 
             it('should save the platform metadata', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true, restoring:true}).then(function(result) {
+                platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, fetch: true, restoring: true}).then(function (result) {
                     expect(platform_metadata.save).toHaveBeenCalledWith('/some/path', 'atari', undefined);
                 }).fail(function (err) {
                     fail('unexpected failure handler invoked!');
@@ -257,7 +257,7 @@ describe('cordova/platform/addHelper', function () {
             });
 
             it('should write out the version of platform just added/updated to config.xml if the save option is provided', function (done) {
-                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, restoring:true}).then(function(result) {
+                platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, restoring: true}).then(function (result) {
                     expect(cfg_parser_mock.prototype.removeEngine).toHaveBeenCalled();
                     expect(cfg_parser_mock.prototype.addEngine).toHaveBeenCalled();
                     expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
@@ -268,17 +268,17 @@ describe('cordova/platform/addHelper', function () {
             });
 
             describe('if the project contains a package.json', function () {
-                it('should write out the platform just added/updated to the cordova.platforms property of package.json',function (done) {
-                    fs.existsSync.and.callFake(function(filePath) {
-                        if(path.basename(filePath) === 'package.json') {
+                it('should write out the platform just added/updated to the cordova.platforms property of package.json', function (done) {
+                    fs.existsSync.and.callFake(function (filePath) {
+                        if (path.basename(filePath) === 'package.json') {
                             return true;
                         } else {
                             return false;
                         }
                     });
-                    package_json_mock.cordova = {'platforms':['ios']};
+                    package_json_mock.cordova = {'platforms': ['ios']};
                     cordova_util.requireNoCache.and.returnValue(package_json_mock);
-                    platform_addHelper('add', hooks_mock, projectRoot, ['android'], {save: true, restoring:true}).then(function(result) {
+                    platform_addHelper('add', hooks_mock, projectRoot, ['android'], {save: true, restoring: true}).then(function (result) {
                         expect(fs.writeFileSync).toHaveBeenCalled();
                     }).fail(function (err) {
                         fail('unexpected failure handler invoked!');
@@ -287,9 +287,9 @@ describe('cordova/platform/addHelper', function () {
                 });
 
                 it('should only write the package.json file if it was modified', function (done) {
-                    package_json_mock.cordova = {'platforms':['ios']};
+                    package_json_mock.cordova = {'platforms': ['ios']};
                     cordova_util.requireNoCache.and.returnValue(package_json_mock);
-                    platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, restoring:true}).then(function(result) {
+                    platform_addHelper('add', hooks_mock, projectRoot, ['ios'], {save: true, restoring: true}).then(function (result) {
                         expect(fs.writeFileSync).not.toHaveBeenCalled();
                     }).fail(function (err) {
                         fail('unexpected failure handler invoked!');
@@ -297,9 +297,9 @@ describe('cordova/platform/addHelper', function () {
                     }).done(done);
                 });
 
-                it('should file the after_platform_* hook',function (done) {
-                    platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, restoring:true}).then(function(result) {
-                        expect(hooks_mock.fire).toHaveBeenCalledWith( 'before_platform_add', Object({ save: true, restoring: true, searchpath: undefined }));
+                it('should file the after_platform_* hook', function (done) {
+                    platform_addHelper('add', hooks_mock, projectRoot, ['atari'], {save: true, restoring: true}).then(function (result) {
+                        expect(hooks_mock.fire).toHaveBeenCalledWith('before_platform_add', Object({ save: true, restoring: true, searchpath: undefined }));
                     }).fail(function (err) {
                         fail('unexpected failure handler invoked!');
                         console.error(err);
@@ -334,7 +334,7 @@ describe('cordova/platform/addHelper', function () {
                     expect(Q.reject).toHaveBeenCalled();
                     expect(events.emit).toHaveBeenCalledWith('verbose', 'Cloning failed. Let\'s try handling it as a tarball');
                 }).done(done);
-            },60000);
+            }, 60000);
 
             it('should reject the promise should lazy_load.based_on_config fail', function (done) {
                 spyOn(gitclone, 'clone').and.callThrough();
@@ -347,7 +347,7 @@ describe('cordova/platform/addHelper', function () {
                     expect(Q.reject).toHaveBeenCalled();
                     expect(lazy_load.based_on_config).not.toHaveBeenCalled();
                 }).done(done);
-            },60000);
+            }, 60000);
 
             it('should reject the promise should both git_clone and based_on_config fail after the latter was fallen back on', function (done) {
                 lazy_load.git_clone.and.returnValue(Q.reject('git_clone failed'));
@@ -359,7 +359,7 @@ describe('cordova/platform/addHelper', function () {
                 }).fail(function (e) {
                     expect(Q.reject).toHaveBeenCalled();
                 }).done(done);
-            },60000);
+            }, 60000);
         });
         describe('happy path', function () {
             it('should invoke cordova-fetch if fetch was provided as an option', function (done) {
@@ -383,35 +383,35 @@ describe('cordova/platform/addHelper', function () {
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
                 }).done(done);
-            },60000);
+            }, 60000);
 
             it('should attempt to lazy_load.based_on_config if lazy_load.git_clone fails', function (done) {
                 cordova_util.isUrl.and.returnValue(true);
                 platform_addHelper.downloadPlatform(projectRoot, 'android', 'https://github.com/apache/cordova-android', {save: true}).then(function () {
                     expect(events.emit).toHaveBeenCalledWith('verbose', '"git" command line tool is not installed: make sure it is accessible on your PATH.');
-                    expect(events.emit).toHaveBeenCalledWith('verbose','Cloning failed. Let\'s try handling it as a tarball');
+                    expect(events.emit).toHaveBeenCalledWith('verbose', 'Cloning failed. Let\'s try handling it as a tarball');
                     expect(lazy_load.based_on_config).toHaveBeenCalled();
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
                 }).done(done);
-            },60000);
-            
+            }, 60000);
+
             it('should by default attempt to lazy_load.based_on_config', function (done) {
-                platform_addHelper.downloadPlatform(projectRoot, 'android', '6.0.0', {save:true}).then(function () {
+                platform_addHelper.downloadPlatform(projectRoot, 'android', '6.0.0', {save: true}).then(function () {
                     expect(lazy_load.based_on_config).toHaveBeenCalledWith('/some/path', 'android@6.0.0', Object({ save: true }));
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
                 }).done(done);
-            },60000);
+            }, 60000);
 
             it('should pass along a libDir argument to getPlatformDetailsFromDir on a successful platform download', function (done) {
                 cordova_util.isUrl.and.returnValue(true);
-                platform_addHelper.downloadPlatform(projectRoot, 'android', 'https://github.com/apache/cordova-android', {save:true}).then(function () {
+                platform_addHelper.downloadPlatform(projectRoot, 'android', 'https://github.com/apache/cordova-android', {save: true}).then(function () {
                     expect(require('../../../src/cordova/platform/index').getPlatformDetailsFromDir).toHaveBeenCalled();
                 }).fail(function (e) {
                     fail('fail handler unexpectedly invoked');
                 }).done(done);
-            },60000);
+            }, 60000);
         });
     });
     describe('installPluginsForNewPlatform', function () {
@@ -432,7 +432,7 @@ describe('cordova/platform/addHelper', function () {
         it('should invoke plugman.install, giving correct platform, plugin and other arguments', function (done) {
             spyOn(cordova_util, 'findPlugins').and.returnValue(['cordova-plugin-whitelist']);
             fetch_metadata.get_fetch_metadata.and.returnValue({ });
-            platform_addHelper.installPluginsForNewPlatform('browser', projectRoot, {save:true , fetch:true}).then(function () {
+            platform_addHelper.installPluginsForNewPlatform('browser', projectRoot, {save: true, fetch: true}).then(function () {
                 expect(plugman.install).toHaveBeenCalled();
                 expect(events.emit).toHaveBeenCalledWith('verbose', 'Installing plugin "cordova-plugin-whitelist" following successful platform add of browser');
             }).fail(function (e) {
@@ -443,9 +443,9 @@ describe('cordova/platform/addHelper', function () {
         it('should include any plugin variables as options when invoking plugman install', function (done) {
             spyOn(cordova_util, 'findPlugins').and.returnValue(['cordova-plugin-camera']);
             fetch_metadata.get_fetch_metadata.and.returnValue({ source: {}, variables: {} });
-            platform_addHelper.installPluginsForNewPlatform('browser', projectRoot, {save:true , fetch:true}).then(function () {
+            platform_addHelper.installPluginsForNewPlatform('browser', projectRoot, {save: true, fetch: true}).then(function () {
                 expect(plugman.install).toHaveBeenCalled();
-                expect(events.emit).toHaveBeenCalledWith( 'verbose', 'Found variables for "cordova-plugin-camera". Processing as cli_variables.' );
+                expect(events.emit).toHaveBeenCalledWith('verbose', 'Found variables for "cordova-plugin-camera". Processing as cli_variables.');
             }).fail(function (e) {
                 fail('fail handler unexpectedly invoked');
             }).done(done);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message