cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject cordova-browser git commit: CB-11181 add default favicon
Date Mon, 26 Jun 2017 23:28:05 GMT
Repository: cordova-browser
Updated Branches:
  refs/heads/master 7944f4652 -> db6d11802


CB-11181 add default favicon


Project: http://git-wip-us.apache.org/repos/asf/cordova-browser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-browser/commit/db6d1180
Tree: http://git-wip-us.apache.org/repos/asf/cordova-browser/tree/db6d1180
Diff: http://git-wip-us.apache.org/repos/asf/cordova-browser/diff/db6d1180

Branch: refs/heads/master
Commit: db6d1180296b8578a596e6f03d5b4adc49e5fff6
Parents: 7944f46
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Authored: Mon Jun 26 16:22:50 2017 -0700
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Mon Jun 26 16:22:50 2017 -0700

----------------------------------------------------------------------
 bin/lib/create.js            |  21 +++++++++++----------
 bin/template/www/favicon.ico | Bin 0 -> 1150 bytes
 2 files changed, 11 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-browser/blob/db6d1180/bin/lib/create.js
----------------------------------------------------------------------
diff --git a/bin/lib/create.js b/bin/lib/create.js
index 483407b..fa6b5c9 100644
--- a/bin/lib/create.js
+++ b/bin/lib/create.js
@@ -35,6 +35,7 @@ module.exports.createProject = function(project_path,package_name,project_name){
     // create the dest and the standard place for our api to live
     // platforms/platformName/cordova/Api.js
 */
+
     events.emit('log', 'Creating Cordova project for cordova-browser:');
     events.emit('log', '\tPath: ' + project_path);
     events.emit('log', '\tName: ' + project_name);
@@ -69,26 +70,26 @@ module.exports.createProject = function(project_path,package_name,project_name){
     shell.cp(path.join(ROOT, 'bin/lib/check_reqs.js'),
              path.join(project_path,'cordova/lib'));
 
+    var platform_www = path.join(project_path,'platform_www');
+
     //copy cordova-js-src directory
-    shell.cp('-rf', path.join(ROOT, 'cordova-js-src'),
-                    path.join(project_path, 'platform_www'));
+    shell.cp('-rf', path.join(ROOT, 'cordova-js-src'),platform_www);
 
     //copy cordova js file to platform_www
-    shell.cp(path.join(ROOT, 'cordova-lib', 'cordova.js'),
-             path.join(project_path,'platform_www'));
+    shell.cp(path.join(ROOT, 'cordova-lib', 'cordova.js'),platform_www);
+
+    //copy favicon file to platform_www
+    shell.cp(path.join(ROOT, 'bin/template/www/favicon.ico'),platform_www);
 
-    //copy manifest file to platform_www
-    var platform_www = path.join(project_path,'platform_www');
     // load manifest to write name/shortname
     var manifest = require(path.join(ROOT, 'bin/template/www', 'manifest.json'));
     manifest.name = project_name;
     manifest.short_name = project_name;
-    fs.writeFileSync(path.join(project_path,'platform_www','manifest.json'),
+    // copy manifest file to platform_www
+    fs.writeFileSync(path.join(platform_www,'manifest.json'),
                      JSON.stringify(manifest, null, 2), 'utf-8');
     // copy service worker
-    shell.cp(path.join(ROOT, 'bin/template/www', 'cordova-sw.js'),
-             path.join(project_path,'platform_www'));
-
+    shell.cp(path.join(ROOT, 'bin/template/www', 'cordova-sw.js'),platform_www);
 
     return Promise.resolve();
 };

http://git-wip-us.apache.org/repos/asf/cordova-browser/blob/db6d1180/bin/template/www/favicon.ico
----------------------------------------------------------------------
diff --git a/bin/template/www/favicon.ico b/bin/template/www/favicon.ico
new file mode 100644
index 0000000..fa7a758
Binary files /dev/null and b/bin/template/www/favicon.ico differ


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message