cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [1/2] cordova-lib git commit: CB-12705: Modified (before|after)_plugin_(uninstall|install) to always expect existence of plugin field
Date Mon, 01 May 2017 21:48:15 GMT
Repository: cordova-lib
Updated Branches:
  refs/heads/master 677d2529c -> 665197fee


CB-12705: Modified (before|after)_plugin_(uninstall|install) to always expect existence of
plugin field

 This closes #549


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/665197fe
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/665197fe
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/665197fe

Branch: refs/heads/master
Commit: 665197fee09f53bd6a84d5875e520abffa1bd432
Parents: f038ca4
Author: feichngr <fabian.eichinger@gmail.com>
Authored: Wed Apr 26 07:45:01 2017 +0200
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Mon May 1 23:47:31 2017 +0200

----------------------------------------------------------------------
 cordova-lib/spec-cordova/HooksRunner.spec.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/665197fe/cordova-lib/spec-cordova/HooksRunner.spec.js
----------------------------------------------------------------------
diff --git a/cordova-lib/spec-cordova/HooksRunner.spec.js b/cordova-lib/spec-cordova/HooksRunner.spec.js
index 28d7d5f..e121ee3 100644
--- a/cordova-lib/spec-cordova/HooksRunner.spec.js
+++ b/cordova-lib/spec-cordova/HooksRunner.spec.js
@@ -453,7 +453,8 @@ describe('HooksRunner', function() {
                             if(call.args[0] == 'before_plugin_uninstall' ||
                                 call.args[0] == 'before_plugin_install' ||
                                 call.args[0] == 'after_plugin_install') {
-                                if(call.args[1] && call.args[1].plugin) {
+                                if(call.args[1]) {
+                                    expect(call.args[1].plugin).toBeDefined();
                                     if(call.args[1].plugin.platform == 'android') {
                                         expect(JSON.stringify(androidPluginOpts) ===
                                             JSON.stringify(call.args[1])).toBe(true);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message