cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [2/2] cordova-lib git commit: CB-11908 : updated tests to use jasmine 2.0
Date Wed, 19 Apr 2017 19:21:37 GMT
CB-11908 : updated tests to use jasmine 2.0

 This closes #537, this closes #508


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/93672b7f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/93672b7f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/93672b7f

Branch: refs/heads/master
Commit: 93672b7fe9644e8b02d352364d7848deca3c3c69
Parents: 48e6562
Author: Audrey So <audreyso@apache.org>
Authored: Wed Apr 5 15:11:10 2017 -0700
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Wed Apr 19 12:13:11 2017 -0700

----------------------------------------------------------------------
 cordova-common/spec/ConfigChanges/ConfigChanges.spec.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/93672b7f/cordova-common/spec/ConfigChanges/ConfigChanges.spec.js
----------------------------------------------------------------------
diff --git a/cordova-common/spec/ConfigChanges/ConfigChanges.spec.js b/cordova-common/spec/ConfigChanges/ConfigChanges.spec.js
index 5af26a3..096a8ec 100644
--- a/cordova-common/spec/ConfigChanges/ConfigChanges.spec.js
+++ b/cordova-common/spec/ConfigChanges/ConfigChanges.spec.js
@@ -314,24 +314,24 @@ describe('config-changes module', function() {
                 it('should call graftXMLMerge for every new config.xml config munge with
mode \'merge\' it introduces', function() {
                     var platformJson = PlatformJson.load(plugins_dir, 'android');
 
-                    var spy = spyOn(xml_helpers, 'graftXMLMerge').andReturn(true);
+                    var spy = spyOn(xml_helpers, 'graftXMLMerge').and.returnValue(true);
 
                     var munger = new configChanges.PlatformMunger('android', temp, platformJson);
                     munger.add_config_changes(cfg, true);
 
-                    expect(spy.calls.length).toEqual(1);
-                    expect(spy.argsForCall[0][2]).toEqual('/manifest/uses-sdk');
+                    expect(spy.calls.count()).toEqual(1);
+                    expect(spy.calls.argsFor(0)[2]).toEqual('/manifest/uses-sdk');
                 });
                 it('should call graftXMLOverwrite for every new config.xml config munge with
mode \'overwrite\' it introduces', function() {
                     var platformJson = PlatformJson.load(plugins_dir, 'android');
 
-                    var spy = spyOn(xml_helpers, 'graftXMLOverwrite').andReturn(true);
+                    var spy = spyOn(xml_helpers, 'graftXMLOverwrite').and.returnValue(true);
 
                     var munger = new configChanges.PlatformMunger('android', temp, platformJson);
                     munger.add_config_changes(cfg, true);
 
-                    expect(spy.calls.length).toEqual(1);
-                    expect(spy.argsForCall[0][2]).toEqual('/manifest/uses-sdk');
+                    expect(spy.calls.count()).toEqual(1);
+                    expect(spy.calls.argsFor(0)[2]).toEqual('/manifest/uses-sdk');
                 });
                 it('should call pruneXMLRemove for every new config.xml config munge with
mode \'remove\' it introduces', function() {
                     var platformJson = PlatformJson.load(plugins_dir, 'android');


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message