cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [4/7] cordova-cli git commit: CB-11982 : updated info about new config command
Date Thu, 20 Apr 2017 00:21:24 GMT
CB-11982 : updated info about new config command


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/d34e5969
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/d34e5969
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/d34e5969

Branch: refs/heads/master
Commit: d34e59696d458f80d9a3e72354cefd2eba0199c2
Parents: 7c035ce
Author: Audrey So <audreyso@apache.org>
Authored: Fri Mar 10 09:26:02 2017 -0800
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Wed Apr 19 14:34:53 2017 -0700

----------------------------------------------------------------------
 doc/config.txt   |  2 +-
 doc/cordova.txt  |  5 ++++-
 spec/cli.spec.js | 45 +++++++++++++++++++++++----------------------
 src/cli.js       |  4 ----
 4 files changed, 28 insertions(+), 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/d34e5969/doc/config.txt
----------------------------------------------------------------------
diff --git a/doc/config.txt b/doc/config.txt
index f79b41b..6eb017d 100644
--- a/doc/config.txt
+++ b/doc/config.txt
@@ -3,7 +3,7 @@ Synopsis
     cordova-cli config <command> [options]
     
 
-The config command can be used to set, get, delete, and edit the 
+The config command can be used to set, get, delete, edit, and list the 
 contents of the user files.
 
 Options

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/d34e5969/doc/cordova.txt
----------------------------------------------------------------------
diff --git a/doc/cordova.txt b/doc/cordova.txt
index 86ad0de..f54d8ac 100644
--- a/doc/cordova.txt
+++ b/doc/cordova.txt
@@ -6,6 +6,8 @@ Global Commands
     create ............................. Create a project
     help ............................... Get help for a command
     telemetry .......................... Turn telemetry collection on or off
+    config ............................. Store and retrieve environment variables 
+                                         (set, get, delete, edit, list)
 
 Project Commands
     info ............................... Generate project information
@@ -46,4 +48,5 @@ Examples
     cordova-cli requirements android    
     cordova-cli build android --verbose
     cordova-cli run android
-    cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android
--alias=mykey
\ No newline at end of file
+    cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android
--alias=mykey
+    cordova-cli config ls
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/d34e5969/spec/cli.spec.js
----------------------------------------------------------------------
diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index e01a291..e390282 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -456,29 +456,8 @@ describe("platform", function () {
             done();
         });
     });
-
-    it("Test #044 : config edit is called", function (done) {
-        cli(["node", "cordova", "config", "edit"], function () {
-            expect(cordova.raw.config).toHaveBeenCalledWith(
-                'edit',
-                [ ],
-                jasmine.any(Object)
-            );
-            done();
-        });
-    });
-
-    it("Test #045 : config edit is called", function (done) {
-        cli(["node", "cordova", "config", "ls"], function () {
-            expect(cordova.raw.config).toHaveBeenCalledWith(
-                'ls',
-                [ ],
-                jasmine.any(Object)
-            );
-            done();
-        });
-    });
 });
+
 describe("config", function () {
     beforeEach(function () {
         spyOn(cordova.raw, "config").and.returnValue(Q());
@@ -534,4 +513,26 @@ describe("config", function () {
             done();
         });
     });
+
+    it("Test #044 : config edit is called", function (done) {
+        cli(["node", "cordova", "config", "edit"], function () {
+            expect(cordova.raw.config).toHaveBeenCalledWith(
+                'edit',
+                [ ],
+                jasmine.any(Object)
+            );
+            done();
+        });
+    });
+
+    it("Test #045 : config edit is called", function (done) {
+        cli(["node", "cordova", "config", "ls"], function () {
+            expect(cordova.raw.config).toHaveBeenCalledWith(
+                'ls',
+                [ ],
+                jasmine.any(Object)
+            );
+            done();
+        });
+    });
 });
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/d34e5969/src/cli.js
----------------------------------------------------------------------
diff --git a/src/cli.js b/src/cli.js
index 16265cd..542b1bb 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -125,11 +125,7 @@ module.exports = function (inputArgs, cb) {
         cmd = 'help';
     }
 
-    // Q.then is here or after this?
-    Q().then(function() {
-
     // If "get" is called
-
     if (isConfigCmd && inputArgs[3] === 'get') {
         if (inputArgs[4]) {
             logger.subscribe(events);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message