cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fil...@apache.org
Subject [26/35] cordova-coho git commit: One more confirm dialog before we start changing plugin repos during release.
Date Wed, 26 Apr 2017 01:04:21 GMT
One more confirm dialog before we start changing plugin repos during release.


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/056c0dfb
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/056c0dfb
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/056c0dfb

Branch: refs/heads/master
Commit: 056c0dfb30ba0441049730e0709aa99b7c787ed0
Parents: fe986f3
Author: filmaj <maj.fil@gmail.com>
Authored: Fri Mar 3 20:02:02 2017 -0800
Committer: filmaj <maj.fil@gmail.com>
Committed: Tue Apr 25 17:28:08 2017 -0700

----------------------------------------------------------------------
 src/plugin-release.js | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/056c0dfb/src/plugin-release.js
----------------------------------------------------------------------
diff --git a/src/plugin-release.js b/src/plugin-release.js
index 03683e6..9a996f8 100644
--- a/src/plugin-release.js
+++ b/src/plugin-release.js
@@ -379,12 +379,23 @@ function *interactive_plugins_release() {
                 console.log('No license issues found - continuing.');
             }
         }).then(function() {
+            return inquirer.prompt({
+                type: 'confirm',
+                name: 'proceed',
+                message: 'We are now ready to start making changes to the selected plugin
repo, which will make changes to the master and release branches. Shall we proceed?'
+            }).then(function(answers) {
+                if (!answers.proceed) {
+                    console.error('Bailing!');
+                    process.exit(99);
+                }
+            });
+        }).then(function() {
             // TODO: step 8 apparently is "rarely" done based on fil's experience running
through the plugin release steps manually.
             // soooo.... what do?
             /* 8. ensure all dependencies and subdependencies have apache-compatible licenses.
              * 9. update plugin versions + release notes.
              *   - for each plugin, remove the `-dev` suffix in plugin.xml, package.json,
and plugin.xml of `tests/` subdirectory (if exists)*/
-            console.log('Removing the "-dev" suffix from versions...');
+            console.log('Removing the "-dev" suffix from versions in the master branch...');
             return co.wrap(function *() {
                 yield repoutil.forEachRepo(plugin_repos, function*(repo) {
                     yield gitutil.gitCheckout('master');
@@ -476,6 +487,7 @@ function *interactive_plugins_release() {
                         repos_with_existing_release_branch.push(repo);
                         // also store HEAD of release branch, so later on we can show a diff
of the branch before pushing
                         plugin_data[plugin_name].previous_release_branch_head = gitutil.hashForRef(release_branch_name);
+                        console.log('Release branch', release_branch_name, 'already exists
- we will be making changes to this existing branch.');
                     } else {
                         yield gitutil.createNewBranch(release_branch_name);
                         console.log('Created branch', release_branch_name, 'in repo', plugin_name);
@@ -488,7 +500,6 @@ function *interactive_plugins_release() {
             // Our mission in this clause, should we choose to accept it, is to merge master
back into the branch. But, this can be dangerous!
             // Ask the RM if they want us to handle the merge automatically.
             // If the RM says no, we will prompt them to handle it manually later.
-            console.warn('Some release branches already exist!');
             var prompts = [];
             repos_with_existing_release_branch.forEach(function(repo) {
                 var plugin_name = repo.repoName;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message