cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fil...@apache.org
Subject cordova-plugin-contacts git commit: Pulled out appium session destruction into a jasmine `afterAll` teardown function (instead of its own test). Tweaking some labels.
Date Wed, 14 Dec 2016 21:15:05 GMT
Repository: cordova-plugin-contacts
Updated Branches:
  refs/heads/master 568340021 -> 7c4f94f48


Pulled out appium session destruction into a jasmine `afterAll` teardown function (instead
of its own test). Tweaking some labels.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/7c4f94f4
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/7c4f94f4
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/7c4f94f4

Branch: refs/heads/master
Commit: 7c4f94f483fbe90d49e0d273cf8a8f7260f36d20
Parents: 5683400
Author: filmaj <maj.fil@gmail.com>
Authored: Fri Dec 9 15:22:35 2016 -0800
Committer: filmaj <maj.fil@gmail.com>
Committed: Wed Dec 14 13:14:06 2016 -0800

----------------------------------------------------------------------
 appium-tests/common/common.spec.js | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/7c4f94f4/appium-tests/common/common.spec.js
----------------------------------------------------------------------
diff --git a/appium-tests/common/common.spec.js b/appium-tests/common/common.spec.js
index 67133ae..956430b 100644
--- a/appium-tests/common/common.spec.js
+++ b/appium-tests/common/common.spec.js
@@ -37,7 +37,7 @@ var MINUTE = 60 * 1000;
 var PLATFORM = global.PLATFORM;
 var UNORM = global.UNORM;
 
-describe('Contacts Android', function () {
+describe('Contacts UI Automation Tests', function () {
     var driver;
     var webviewContext;
     var promiseCount = 0;
@@ -232,7 +232,14 @@ describe('Contacts Android', function () {
         }
     }
 
-    it('contacts.ui.util configuring driver and starting a session', function (done) {
+    afterAll(function (done) {
+        checkSession(done);
+        driver
+            .quit()
+            .done(done);
+    }, MINUTE);
+
+    it('should connect to an appium endpoint properly', function (done) {
         getDriver()
             .then(function () {
                 failedToStart = false;
@@ -335,11 +342,4 @@ describe('Contacts Android', function () {
                 .done(done);
         }, 5 * MINUTE);
     });
-
-    it('contacts.ui.util Destroy the session', function (done) {
-        checkSession(done);
-        driver
-            .quit()
-            .done(done);
-    }, 5 * MINUTE);
 });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message