cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [01/12] cordova-plugin-dialogs git commit: Make sure the alert buttonLabel is a string
Date Thu, 08 Dec 2016 00:56:44 GMT
Repository: cordova-plugin-dialogs
Updated Branches:
  refs/heads/1.3.x fef904c72 -> 233aff26f


Make sure the alert buttonLabel is a string


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/5ecb3506
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/5ecb3506
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/5ecb3506

Branch: refs/heads/1.3.x
Commit: 5ecb3506e0de87d0465713857af132e68c543f00
Parents: 7c4a5de
Author: Kevin Boosten <kevin.boosten@qnh.nl>
Authored: Tue Aug 16 09:34:00 2016 +0200
Committer: Kevin Boosten <kevin.boosten@qnh.nl>
Committed: Tue Aug 16 09:34:00 2016 +0200

----------------------------------------------------------------------
 www/notification.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/5ecb3506/www/notification.js
----------------------------------------------------------------------
diff --git a/www/notification.js b/www/notification.js
index 4db8f0f..751f4ce 100644
--- a/www/notification.js
+++ b/www/notification.js
@@ -39,7 +39,7 @@ module.exports = {
     alert: function(message, completeCallback, title, buttonLabel) {
         var _message = (typeof message === "string" ? message : JSON.stringify(message));
         var _title = (typeof title === "string" ? title : "Alert");
-        var _buttonLabel = (buttonLabel || "OK");
+        var _buttonLabel = (typeof buttonLabel === "string" ? buttonLabel : "OK");
         exec(completeCallback, null, "Notification", "alert", [_message, _title, _buttonLabel]);
     },
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message