cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [2/2] cordova-plugin-wkwebview-engine git commit: CB-11997: Code review comments
Date Mon, 05 Dec 2016 22:52:17 GMT
CB-11997: Code review comments

 This closes #23


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/commit/d5591dec
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/tree/d5591dec
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/diff/d5591dec

Branch: refs/heads/master
Commit: d5591deceba8936b9bfb7a0d04e60504ed12e407
Parents: d9d30f2
Author: Connor Pearson <cjp822@gmail.com>
Authored: Wed Nov 30 07:29:10 2016 -0500
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Mon Dec 5 14:52:07 2016 -0800

----------------------------------------------------------------------
 src/ios/CDVWKWebViewEngine.m | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/blob/d5591dec/src/ios/CDVWKWebViewEngine.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVWKWebViewEngine.m b/src/ios/CDVWKWebViewEngine.m
index 9ab0d5c..e43c7ba 100644
--- a/src/ios/CDVWKWebViewEngine.m
+++ b/src/ios/CDVWKWebViewEngine.m
@@ -134,7 +134,7 @@
 static void * KVOContext = &KVOContext;
 
 - (void)addURLObserver {
-    if(![[NSProcessInfo processInfo] isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion
= 9, .minorVersion = 0, .patchVersion = 0 }]){
+    if(!IsAtLeastiOSVersion(@"9.0")){
         [self.webView addObserver:self forKeyPath:@"URL" options:0 context:KVOContext];
     }
 }
@@ -143,7 +143,7 @@ static void * KVOContext = &KVOContext;
 {
     if (context == KVOContext) {
         if (object == [self webView] && [keyPath isEqualToString: @"URL"] &&
[object valueForKeyPath:keyPath] == nil){
-            NSLog(@"URL is nil. Reloading WebView");
+            NSLog(@"URL is nil. Reloading WKWebView");
             [(WKWebView*)_engineWebView reload];
         }
     } else {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message