cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dase...@apache.org
Subject [10/21] cordova-windows git commit: CB-11857 Fixed VS 2015 detection on Windows 10 Anniversary
Date Mon, 24 Oct 2016 10:35:32 GMT
CB-11857 Fixed VS 2015 detection on Windows 10 Anniversary


Project: http://git-wip-us.apache.org/repos/asf/cordova-windows/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-windows/commit/50bbc3e8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-windows/tree/50bbc3e8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-windows/diff/50bbc3e8

Branch: refs/heads/4.4.x
Commit: 50bbc3e8a68616750e47a78f114eaeae67fafc0a
Parents: fbc412e
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Authored: Thu Sep 15 15:07:43 2016 +0300
Committer: daserge <v-seshak@microsoft.com>
Committed: Thu Oct 20 20:54:55 2016 +0300

----------------------------------------------------------------------
 bin/lib/check_reqs.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/50bbc3e8/bin/lib/check_reqs.js
----------------------------------------------------------------------
diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index 9e31fda..dd41b81 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -150,7 +150,7 @@ function getInstalledVSVersions() {
         .fail(function () {
             // if we got any errors on previous steps, we're assuming that
             // required VS update is not installed.
-            installedVersions.splice(installedVersions.indexOf('12.0'));
+            installedVersions.splice(installedVersions.indexOf('12.0'), 1);
             return installedVersions;
         });
     });
@@ -346,7 +346,7 @@ module.exports.run = function () {
 
 /** Checks if Windows SDK required to build the target_platform is present
  * @param {String}  target_platorm        Target platform ('8.1' or '10.0')
- */ 
+ */
 module.exports.isWinSDKPresent = function (target_platform) {
     return checkWinSdk(target_platform, '8.1');
 };
@@ -421,9 +421,9 @@ module.exports.check_all = function() {
                     if (requirement.isFatal) fatalIsHit = true;
                     requirement.metadata.reason = err;
                     result.push(requirement);
-                });  
+                });
             });
-            
+
         });
     }, Q())
     .then(function () {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message