cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject cordova-plugin-wkwebview-engine git commit: CB-11554 - fixed unit tests
Date Thu, 08 Sep 2016 09:54:03 GMT
Repository: cordova-plugin-wkwebview-engine
Updated Branches:
  refs/heads/master a4f3e8848 -> 88054455c


CB-11554 - fixed unit tests


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/commit/88054455
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/tree/88054455
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/diff/88054455

Branch: refs/heads/master
Commit: 88054455c24f0d66e907c1019c7baa96c64ebf5e
Parents: a4f3e88
Author: Shazron Abdullah <shazron@apache.org>
Authored: Thu Sep 8 02:53:52 2016 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Thu Sep 8 02:53:52 2016 -0700

----------------------------------------------------------------------
 .../CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m           | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-wkwebview-engine/blob/88054455/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m
----------------------------------------------------------------------
diff --git a/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m
b/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m
index d306b79..0c359c2 100644
--- a/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m
+++ b/tests/ios/CDVWKWebViewEngineTest/CDVWKWebViewEngineLibTests/CDVWKWebViewEngineTest.m
@@ -204,7 +204,8 @@
     XCTAssertFalse([self.plugin shouldReloadWebView]);
     
     // document with empty title should *not* reload
-    [wkWebView loadHTMLString:empty_title_document baseURL:nil];
+    // baseURL:nil results in about:blank, so we use a dummy here
+    [wkWebView loadHTMLString:empty_title_document baseURL:[NSURL URLWithString:@"about:"]];
     XCTAssertFalse([self.plugin shouldReloadWebView]);
 
     // Anecdotal assertion that when the WKWebView process has died,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message