cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From an-s...@apache.org
Subject cordova-paramedic git commit: CB-11472 Always deploy to simulator
Date Thu, 23 Jun 2016 09:18:03 GMT
Repository: cordova-paramedic
Updated Branches:
  refs/heads/master 257ba7eae -> 09d861aef


CB-11472 Always deploy to simulator


Project: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/commit/09d861ae
Tree: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/tree/09d861ae
Diff: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/diff/09d861ae

Branch: refs/heads/master
Commit: 09d861aefb7f1628e4c5c91823e0b0c08559cbc5
Parents: 257ba7e
Author: Vladimir <v-vlkoti@microsoft.com>
Authored: Thu Jun 23 11:33:30 2016 +0300
Committer: Vladimir <v-vlkoti@microsoft.com>
Committed: Thu Jun 23 11:33:30 2016 +0300

----------------------------------------------------------------------
 lib/paramedic.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-paramedic/blob/09d861ae/lib/paramedic.js
----------------------------------------------------------------------
diff --git a/lib/paramedic.js b/lib/paramedic.js
index 33fa7ef..b2c83a1 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -277,11 +277,19 @@ ParamedicRunner.prototype.getCommandForStartingTests = function () {
         return Q(cmd);
     }
 
-    return paramedicTargetChooser.chooseTarget(true)
+    // For now we always trying to run test app on emulator
+    return paramedicTargetChooser.chooseTarget(/*useEmulator=*/true)
     .then(function(targetObj){
         self.targetObj = targetObj;
         cmd += ' --target ' + self.targetObj.target;
 
+        // CB-11472 In case of iOS provide additional '--emulator' flag, otherwise
+        // 'cordova run ios --target' would hang waiting for device with name
+        // as specified in 'target' in case if any device is physically connected
+        if (self.config.getPlatformId() === 'ios') {
+            cmd += ' --emulator';
+        }
+
         if (self.config.getArgs()) {
             cmd += ' ' + self.config.getArgs();
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message