cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsoro...@apache.org
Subject cordova-paramedic git commit: Better fallback to local testing when platform is not ios or android
Date Tue, 07 Jun 2016 10:38:17 GMT
Repository: cordova-paramedic
Updated Branches:
  refs/heads/master 18da15fb7 -> 39c200d2c


Better fallback to local testing when platform is not ios or android


Project: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/commit/39c200d2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/tree/39c200d2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-paramedic/diff/39c200d2

Branch: refs/heads/master
Commit: 39c200d2c062e245ec21faef9635811ea87cbabc
Parents: 18da15f
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Authored: Tue Jun 7 13:37:37 2016 +0300
Committer: Alexander Sorokin <alexander.sorokin@akvelon.com>
Committed: Tue Jun 7 13:37:51 2016 +0300

----------------------------------------------------------------------
 lib/ParamedicConfig.js | 4 ----
 lib/paramedic.js       | 3 ++-
 2 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-paramedic/blob/39c200d2/lib/ParamedicConfig.js
----------------------------------------------------------------------
diff --git a/lib/ParamedicConfig.js b/lib/ParamedicConfig.js
index bdf9036..6d14d42 100644
--- a/lib/ParamedicConfig.js
+++ b/lib/ParamedicConfig.js
@@ -25,10 +25,6 @@ var util = require('./utils').utilities;
 
 function ParamedicConfig(json) {
     this._config = json;
-    // ignore --shouldUseSauce when not running on iOS or Android
-    if (['android', 'ios'].indexOf(this._config.platform) < 0) {
-        this._config.shouldUseSauce = false;
-    }
 }
 
 ParamedicConfig.parseFromArguments = function (argv) {

http://git-wip-us.apache.org/repos/asf/cordova-paramedic/blob/39c200d2/lib/paramedic.js
----------------------------------------------------------------------
diff --git a/lib/paramedic.js b/lib/paramedic.js
index 7cd5818..a450f81 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -320,7 +320,8 @@ ParamedicRunner.prototype.cleanUpProject = function () {
 ParamedicRunner.prototype.checkSauceRequirements = function () {
     if (this.config.shouldUseSauce()) {
         if (this.config.getPlatformId() !== 'android' && this.config.getPlatformId()
!== 'ios') {
-            throw new Error('Saucelabs only supports Android and iOS');
+            logger.warn('Saucelabs only supports Android and iOS, falling back to testing
locally.');
+            this.config.setShouldUseSauce(false);
         } else if (!this.config.getSauceKey()) {
             throw new Error('Saucelabs key not set. Please set it via environmental variable
' +
                 util.SAUCE_KEY_ENV_VAR + ' or pass it with the --sauceKey parameter.');


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message