cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ton...@apache.org
Subject [06/50] cordova-plugin-screen-orientation git commit: Resolves #33 reverted to use delayed vc dismissal
Date Mon, 23 May 2016 13:42:04 GMT
Resolves #33 reverted to use delayed vc dismissal


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/commit/e62c2304
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/tree/e62c2304
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/diff/e62c2304

Branch: refs/heads/master
Commit: e62c2304c31177fdd309c6280030b6359d2260d0
Parents: 0ba5233
Author: Grant Benvenuti <g.benvenuti@pni.com.au>
Authored: Tue Dec 2 06:47:24 2014 +1000
Committer: Grant Benvenuti <g.benvenuti@pni.com.au>
Committed: Tue Dec 2 06:47:24 2014 +1000

----------------------------------------------------------------------
 README.md                       | 4 ++++
 plugin.xml                      | 2 +-
 src/ios/YoikScreenOrientation.m | 8 ++++++--
 3 files changed, 11 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/blob/e62c2304/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index 5f7b745..f10652a 100644
--- a/README.md
+++ b/README.md
@@ -90,6 +90,10 @@ Wraps the com.blackberry.app plugin functions, auto installed as a dependancy.
 
 #Changelog
 
+##1.3.2
+
+* [#33](https://github.com/yoik/cordova-yoik-screenorientation/issues/33) iOS8 Delay Block
+
 ##1.3.0
 
 * [#23](https://github.com/yoik/cordova-yoik-screenorientation/issues/23) iOS8 flicker

http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/blob/e62c2304/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index ba78308..07a9b5d 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -2,7 +2,7 @@
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="net.yoik.cordova.plugins.screenorientation"
-    version="1.3.1">
+    version="1.3.2">
 
     <name>Screen Orientation</name>
     <description>Adds Screen Orientation API lock and unlock functions to the global
screen object in android, iOS and BB10.</description>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-screen-orientation/blob/e62c2304/src/ios/YoikScreenOrientation.m
----------------------------------------------------------------------
diff --git a/src/ios/YoikScreenOrientation.m b/src/ios/YoikScreenOrientation.m
index e06839b..4dd77c3 100644
--- a/src/ios/YoikScreenOrientation.m
+++ b/src/ios/YoikScreenOrientation.m
@@ -77,8 +77,12 @@ SOFTWARE.
     vc.modalPresentationStyle = UIModalPresentationOverFullScreen;
 #endif
 
-    [self.viewController presentViewController:vc animated:NO completion:nil];
-    [self.viewController dismissViewControllerAnimated:NO completion:nil];
+    [self.viewController presentViewController:vc animated:NO completion:^{
+        // added to support iOS8 beta 5, @see issue #19
+        dispatch_after(0, dispatch_get_main_queue(), ^{
+            [self.viewController dismissViewControllerAnimated:NO completion:nil];
+        });
+    }];
 }
 
 @end


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message