cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dba...@apache.org
Subject [3/9] cordova-ubuntu git commit: Tweak debug launch
Date Thu, 19 May 2016 09:54:39 GMT
Tweak debug launch


Project: http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/commit/98a1fe60
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/tree/98a1fe60
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/diff/98a1fe60

Branch: refs/heads/master
Commit: 98a1fe603d70cb0c63904d19c3ee1f5de18740af
Parents: 2b00f30
Author: Alexandre Abreu <alexandre.abreu@canonical.com>
Authored: Tue May 10 10:08:03 2016 -0400
Committer: Alexandre Abreu <alexandre.abreu@canonical.com>
Committed: Tue May 10 10:08:03 2016 -0400

----------------------------------------------------------------------
 bin/templates/project/cordova/lib/run.js | 2 +-
 main.cpp                                 | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/blob/98a1fe60/bin/templates/project/cordova/lib/run.js
----------------------------------------------------------------------
diff --git a/bin/templates/project/cordova/lib/run.js b/bin/templates/project/cordova/lib/run.js
index 580498e..f1335f9 100644
--- a/bin/templates/project/cordova/lib/run.js
+++ b/bin/templates/project/cordova/lib/run.js
@@ -165,7 +165,7 @@ to http://' + getDeviceInetAddress(target) + ':9222');
 
     logger.info('Launching the application on your device.');
 
-    return Devices.adbExecAsync(target, 'shell "DEBUG=1 ubuntu-app-launch  \\`ubuntu-app-triplet
' + appId + '\\`"').then(function () {
+    return Devices.adbExecAsync(target, 'shell "ubuntu-app-launch  \\`ubuntu-app-triplet
' + appId + '\\`"').then(function () {
         logger.rainbow('have fun!');
         Utils.popd();
     });

http://git-wip-us.apache.org/repos/asf/cordova-ubuntu/blob/98a1fe60/main.cpp
----------------------------------------------------------------------
diff --git a/main.cpp b/main.cpp
index 0bf55e6..14818d6 100644
--- a/main.cpp
+++ b/main.cpp
@@ -88,6 +88,12 @@ int main(int argc, char *argv[]) {
             (qEnvironmentVariableIsSet("DEBUG")
              && QString(qgetenv("DEBUG")) == "1");
 
+    // TODO revamp this for something cleaner, uniform
+    // and runtime bound
+#if !defined(NDEBUG)
+    debuggingEnabled = true;
+#endif
+
     view.rootContext()->setContextProperty(
                 "debuggingEnabled", debuggingEnabled);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message