cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject cordova-plugin-statusbar git commit: patched missing _ready method, and changed the way the proxy is installed
Date Tue, 17 May 2016 03:27:59 GMT
Repository: cordova-plugin-statusbar
Updated Branches:
  refs/heads/master fc56eb211 -> b44816662


patched missing _ready method, and changed the way the proxy is installed


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/b4481666
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/b4481666
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/b4481666

Branch: refs/heads/master
Commit: b448166624a29cac607c38b45f454581757eb411
Parents: fc56eb2
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Authored: Mon May 16 18:01:34 2016 -0700
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Mon May 16 18:01:34 2016 -0700

----------------------------------------------------------------------
 plugin.xml                    |  4 ++--
 src/browser/StatusBarProxy.js | 48 ++++++++++++++++++++++++++++++++++++++
 src/browser/statusbar.js      | 39 -------------------------------
 3 files changed, 50 insertions(+), 41 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b4481666/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 9a19905..3e9b826 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -48,8 +48,8 @@
     </platform>
 
     <platform name="browser">
-        <js-module src="src/browser/statusbar.js" name="statusbar.Browser">
-            <merges target="window.StatusBar" />
+        <js-module src="src/browser/StatusBarProxy.js" name="StatusBarProxy">
+            <runs />
         </js-module>
     </platform>
 

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b4481666/src/browser/StatusBarProxy.js
----------------------------------------------------------------------
diff --git a/src/browser/StatusBarProxy.js b/src/browser/StatusBarProxy.js
new file mode 100644
index 0000000..3e90c6c
--- /dev/null
+++ b/src/browser/StatusBarProxy.js
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+function notSupported(win,fail) {
+    //
+    console.log('StatusBar is not supported');
+    setTimeout(function(){
+        win();
+        // note that while it is not explicitly supported, it does not fail
+        // this is really just here to allow developers to test their code in the browser
+        // and if we fail, then their app might as well. -jm
+    },0);
+}
+
+module.exports = {
+    isVisible: false,
+    styleBlackTranslucent:notSupported,
+    styleDefault:notSupported,
+    styleLightContent:notSupported,
+    styleBlackOpaque:notSupported,
+    overlaysWebView:notSupported,
+    styleLightContect: notSupported,
+    backgroundColorByName: notSupported,
+    backgroundColorByHexString: notSupported,
+    hide: notSupported,
+    show: notSupported,
+    _ready:notSupported
+};
+
+require("cordova/exec/proxy").add("StatusBar", module.exports);
+

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b4481666/src/browser/statusbar.js
----------------------------------------------------------------------
diff --git a/src/browser/statusbar.js b/src/browser/statusbar.js
deleted file mode 100644
index 3e9d05e..0000000
--- a/src/browser/statusbar.js
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
- */
-
-function notSupported() {
-    console.log('StatusBar is not supported');
-    return false;
-}
-
-module.exports = {
-    isVisible: false,
-    styleBlackTranslucent:notSupported,
-    styleDefault:notSupported,
-    styleLightContent:notSupported,
-    styleBlackOpaque:notSupported,
-    overlaysWebView:notSupported,
-    styleLightContect: notSupported,
-    backgroundColorByName: notSupported,
-    backgroundColorByHexString: notSupported,
-    hide: notSupported,
-    show: notSupported
-};
-


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message