cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsoro...@apache.org
Subject cordova-medic git commit: CB-11137 Appium runner: don't use deprecated server args
Date Fri, 22 Apr 2016 16:21:38 GMT
Repository: cordova-medic
Updated Branches:
  refs/heads/master bf99e1977 -> 43dd9d160


CB-11137 Appium runner: don't use deprecated server args


Project: http://git-wip-us.apache.org/repos/asf/cordova-medic/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-medic/commit/43dd9d16
Tree: http://git-wip-us.apache.org/repos/asf/cordova-medic/tree/43dd9d16
Diff: http://git-wip-us.apache.org/repos/asf/cordova-medic/diff/43dd9d16

Branch: refs/heads/master
Commit: 43dd9d1606acae2445819f6cbd82f21182dd1c17
Parents: bf99e19
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Authored: Fri Apr 22 12:35:29 2016 +0300
Committer: Alexander Sorokin <alexander.sorokin@akvelon.com>
Committed: Fri Apr 22 13:38:39 2016 +0300

----------------------------------------------------------------------
 lib/appium/helpers/wdHelper.js | 4 +++-
 medic/medic-appium.js          | 9 +--------
 2 files changed, 4 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-medic/blob/43dd9d16/lib/appium/helpers/wdHelper.js
----------------------------------------------------------------------
diff --git a/lib/appium/helpers/wdHelper.js b/lib/appium/helpers/wdHelper.js
index 85186a5..f06913f 100644
--- a/lib/appium/helpers/wdHelper.js
+++ b/lib/appium/helpers/wdHelper.js
@@ -52,13 +52,15 @@ module.exports.getDriver = function (platform) {
 
     var driverConfig = {
         browserName: '',
-        'appium-version': '1.5',
         platformName: normalizedPlatform,
         platformVersion: global.PLATFORM_VERSION || '',
         deviceName: global.DEVICE_NAME || '',
         app: global.PACKAGE_PATH,
         autoAcceptAlerts: true,
     };
+    if (global.UDID) {
+        driverConfig.udid = global.UDID;
+    }
 
     var driver = global.WD.promiseChainRemote(serverConfig);
     module.exports.configureLogging(driver);

http://git-wip-us.apache.org/repos/asf/cordova-medic/blob/43dd9d16/medic/medic-appium.js
----------------------------------------------------------------------
diff --git a/medic/medic-appium.js b/medic/medic-appium.js
index 7c4098b..2cf5f4f 100644
--- a/medic/medic-appium.js
+++ b/medic/medic-appium.js
@@ -57,8 +57,6 @@ var DEFAULT_ANDROID_DEVICE_NAME = "appium";
 var DEFAULT_IOS_PLATFORM_VERSION = "7.1";
 var DEFAULT_ANDROID_PLATFORM_VERSION = "19";
 var KILL_SIGNAL = "SIGINT";
-var APPIUM_IP_ADDRESS = "127.0.0.1";
-var APPIUM_PORT = 4723;
 var SMALL_BUFFER_SIZE = 1024 * 1024;
 var BIG_BUFFER_SIZE = 50 * 1024 * 1024;
 var APPIUM_SERVER_PATH = path.normalize("cordova-medic/node_modules/appium/build/lib/main.js");
@@ -207,6 +205,7 @@ function parseArgs() {
     global.DEVICE_NAME = options.appiumDeviceName;
     global.SCREENSHOT_PATH = options.screenshotPath;
     global.UNORM = unorm;
+    global.UDID = options.udid;
 
     // creating a directory to save screenshots to
     fs.stat(global.SCREENSHOT_PATH, function (err) {
@@ -460,12 +459,6 @@ function startAppiumServer(options, callback) {
     }
 
     appiumServerCommand = "node " + APPIUM_SERVER_PATH +
-        " --address " + APPIUM_IP_ADDRESS +
-        " --port " + APPIUM_PORT +
-        " --platform-name " + appiumPlatformName +
-        " --platform-version " + options.appiumPlatformVersion +
-        " --automation-name Appium --log-no-color" +
-        " --device-name \"" + options.appiumDeviceName + "\"" +
         additionalArgs;
 
     // run the Appium server


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message