cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmob...@apache.org
Subject cordova-plugin-dialogs git commit: CB-10097 dialog doesn't show on iOS when called from a select list onChange event
Date Wed, 06 Apr 2016 21:03:47 GMT
Repository: cordova-plugin-dialogs
Updated Branches:
  refs/heads/master d6ac43956 -> 1485667c8


CB-10097 dialog doesn't show on iOS when called from a select list onChange event

Changed getTopPresentedViewController to not set the
presentingViewController to a ViewController that is being dismissed.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/1485667c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/1485667c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/1485667c

Branch: refs/heads/master
Commit: 1485667c80cbc34da5cf69df174290502eb79b66
Parents: d6ac439
Author: Julio César <jcesarmobile@gmail.com>
Authored: Wed Apr 6 22:42:25 2016 +0200
Committer: Julio César <jcesarmobile@gmail.com>
Committed: Wed Apr 6 22:42:25 2016 +0200

----------------------------------------------------------------------
 src/ios/CDVNotification.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/1485667c/src/ios/CDVNotification.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVNotification.m b/src/ios/CDVNotification.m
index 1742285..d1f1e33 100644
--- a/src/ios/CDVNotification.m
+++ b/src/ios/CDVNotification.m
@@ -220,7 +220,7 @@ static void soundCompletionCallback(SystemSoundID  ssid, void* data) {
 
 -(UIViewController *)getTopPresentedViewController {
     UIViewController *presentingViewController = self.viewController;
-    while(presentingViewController.presentedViewController != nil)
+    while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController
isBeingDismissed])
     {
         presentingViewController = presentingViewController.presentedViewController;
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message