Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66199197C7 for ; Thu, 24 Mar 2016 16:18:13 +0000 (UTC) Received: (qmail 69775 invoked by uid 500); 24 Mar 2016 16:18:13 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 69752 invoked by uid 500); 24 Mar 2016 16:18:13 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 69743 invoked by uid 99); 24 Mar 2016 16:18:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 16:18:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 229D5DFCE0; Thu, 24 Mar 2016 16:18:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: daserge@apache.org To: commits@cordova.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: cordova-plugin-splashscreen git commit: CB-10895 Transparent Splashscreen view sometimes remains Date: Thu, 24 Mar 2016 16:18:13 +0000 (UTC) Repository: cordova-plugin-splashscreen Updated Branches: refs/heads/feature/fade_bug [created] bea0a4e40 CB-10895 Transparent Splashscreen view sometimes remains github: close#92 Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/bea0a4e4 Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/bea0a4e4 Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/bea0a4e4 Branch: refs/heads/feature/fade_bug Commit: bea0a4e4083f2c19b71606f76a334439b0b17b40 Parents: 41d9ae9 Author: Jeroen Verhoest Authored: Mon Mar 14 12:32:11 2016 +0100 Committer: daserge Committed: Thu Mar 24 16:33:23 2016 +0300 ---------------------------------------------------------------------- src/ios/CDVSplashScreen.m | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/bea0a4e4/src/ios/CDVSplashScreen.m ---------------------------------------------------------------------- diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m index 407fde2..1d7b955 100644 --- a/src/ios/CDVSplashScreen.m +++ b/src/ios/CDVSplashScreen.m @@ -456,7 +456,10 @@ [weakSelf hideViews]; } completion:^(BOOL finished) { - if (finished && !_destroyed) { + // Always destroy views, otherwise you could have an + // invisible splashscreen that is overlayed over your active views + // which causes that no touch events are passed + if (!_destroyed) { [weakSelf destroyViews]; // TODO: It might also be nice to have a js event happen here -jm } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org