cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dase...@apache.org
Subject [2/3] cordova-windows git commit: CB-10480 Remove Windows 8 template from cordova-windows
Date Wed, 03 Feb 2016 08:40:57 GMT
CB-10480 Remove Windows 8 template from cordova-windows

Updated check_reqs
Updated the docs


Project: http://git-wip-us.apache.org/repos/asf/cordova-windows/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-windows/commit/5f15c5eb
Tree: http://git-wip-us.apache.org/repos/asf/cordova-windows/tree/5f15c5eb
Diff: http://git-wip-us.apache.org/repos/asf/cordova-windows/diff/5f15c5eb

Branch: refs/heads/master
Commit: 5f15c5eb0fc07cb3a37aaa2f436d03208b1cb80a
Parents: d783f20
Author: daserge <v-seshak@microsoft.com>
Authored: Wed Feb 3 10:53:28 2016 +0300
Committer: daserge <v-seshak@microsoft.com>
Committed: Wed Feb 3 10:53:47 2016 +0300

----------------------------------------------------------------------
 README.md             |  6 ------
 bin/lib/check_reqs.js | 17 ++++++++++-------
 cordova-windows10.md  |  6 ++----
 3 files changed, 12 insertions(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/5f15c5eb/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index d2ae3c2..fa2a510 100644
--- a/README.md
+++ b/README.md
@@ -43,12 +43,6 @@ Host OS: Windows 8.1
 
 Install the tools: [Visual Studio 2013 Express](http://www.visualstudio.com/downloads/download-visual-studio-vs#d-express-windows-8).
 
-### Windows 8 only (deprecated)
-
-Host OS: Windows 8 or 8.1
-
-Install the tools: [Visual Studio 2012 Express](http://www.visualstudio.com/downloads).
-
 #Getting started
 The best way to use this is to install the [Cordova CLI](https://www.npmjs.com/package/cordova),
create a project, add the windows platform, and run the app:
 	

http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/5f15c5eb/bin/lib/check_reqs.js
----------------------------------------------------------------------
diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index 7ba036d..42f67e7 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -43,12 +43,6 @@ try {
 // reference: https://msdn.microsoft.com/en-us/library/bb164659(v=vs.120).aspx
 var VS2013_UPDATE2_RC = new Version(12, 0, 30324);
 var REQUIRED_VERSIONS = {
-    '8.0': {
-        os: '6.2',
-        msbuild: '11.0',
-        visualstudio: '11.0',
-        windowssdk: '8.0'
-    },
     '8.1': {
         os: '6.3',
         msbuild: '12.0',
@@ -83,6 +77,15 @@ function getMinimalRequiredVersionFor (requirement) {
     var config = getConfig();
     var windowsTargetVersion = config.getWindowsTargetVersion();
     var windowsPhoneTargetVersion = config.getWindowsPhoneTargetVersion();
+
+    if (windowsTargetVersion === '8' || windowsTargetVersion === '8.0') {
+        throw new CordovaError('windows8 platform is deprecated. To use windows-target-version=8.0
you may downgrade to cordova-windows@4.');
+    }
+
+    if (windowsPhoneTargetVersion === '8' || windowsPhoneTargetVersion === '8.0') {
+        throw new CordovaError('8.0 is not a valid version for windows-phone-target-version
(use the wp8 Cordova platform instead)');
+    }
+
     var windowsReqVersion = Version.tryParse(REQUIRED_VERSIONS[windowsTargetVersion][requirement]);
     var phoneReqVersion = Version.tryParse(REQUIRED_VERSIONS[windowsPhoneTargetVersion][requirement]);
 
@@ -128,7 +131,7 @@ function getWindowsVersion() {
 }
 
 /**
- * Lists all Visual Studio versions insalled. For VS 2013 if it present, alao
+ * Lists all Visual Studio versions insalled. For VS 2013 if it present, also
  *   checks if Update 2 is installed.
  *
  * @return  {String[]}  List of installed Visual Studio versions.

http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/5f15c5eb/cordova-windows10.md
----------------------------------------------------------------------
diff --git a/cordova-windows10.md b/cordova-windows10.md
index f892715..f148184 100644
--- a/cordova-windows10.md
+++ b/cordova-windows10.md
@@ -41,7 +41,7 @@ To develop apps for Windows 10, you require:
 
 ### Web Context and Windows Runtime Access ###
 
-In Windows 8 and 8.1, loading your app into the web context (using `ms-appx-web://`) would
allow 
+In Windows 8.1, loading your app into the web context (using `ms-appx-web://`) would allow

 developers freedom of certain kinds of document manipulation (such as inline script) but
would 
 prevent Windows Runtime (WinRT) access.  In Windows 10, many of these restrictions have been
lifted; 
 web applications have access to WinRT APIs as long as the page’s origin has been whitelisted
in the 
@@ -106,8 +106,6 @@ package to target.
 
 * 10.0, UAP: Builds for Windows 10 Universal Windows Platform
 * 8.1: Builds for Windows 8.1 or Windows Phone 8.1 (the default)
-* 8.0: Build for Windows 8.0. Not valid for Windows Phone (use the wp8 Cordova platform 
-instead)
 
 **Scenarios**
 
@@ -128,7 +126,7 @@ restrictions, you must set this preference to `ms-appx://` and not declare
any
 
 **Valid Values**
 
-* `ms-appx://` (Default for Windows 8, 8.1): The start page runs in the local context
+* `ms-appx://` (Default for Windows 8.1): The start page runs in the local context
 * `ms-appx-web://` (Default for Windows 10): The start page runs in the web context
 
 #### {SDK}-MinVersion, {SDK}-MaxVersionTested ####


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message