cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From an-s...@apache.org
Subject [2/3] cordova-plugin-statusbar git commit: Fix for CB-10102
Date Tue, 09 Feb 2016 09:52:18 GMT
Fix for CB-10102

The removeObserver code was wrong and it might crash on plugin
deallocation

github: close #45


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/a4645264
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/a4645264
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/a4645264

Branch: refs/heads/2.1.x
Commit: a464526477fecf15c091856d1a152e8eb38be033
Parents: 97f87d3
Author: Julio César <jcesarmobile@gmail.com>
Authored: Sat Jan 16 20:23:36 2016 +0100
Committer: Julio César <jcesarmobile@gmail.com>
Committed: Sun Jan 17 13:56:20 2016 +0100

----------------------------------------------------------------------
 src/ios/CDVStatusBar.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/a4645264/src/ios/CDVStatusBar.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVStatusBar.m b/src/ios/CDVStatusBar.m
index 7e071b2..4077e36 100644
--- a/src/ios/CDVStatusBar.m
+++ b/src/ios/CDVStatusBar.m
@@ -468,7 +468,7 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
 - (void) dealloc
 {
     [[UIApplication sharedApplication] removeObserver:self forKeyPath:@"statusBarHidden"];
-    [[NSNotificationCenter defaultCenter] removeObserver:self forKeyPath:UIApplicationDidChangeStatusBarFrameNotification];
+    [[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification
object:nil];
 }
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message